feat: suggest chain #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsiegart
force-pushed
the
suggest-chain
branch
from
8834eec
to
b78b12f
Compare
turadg
approved these changes
Aug 21, 2023
Comment on lines
+59
to
+64
| // @ts-expect-error Check for Keplr | ||
| const { keplr } = window; | ||
|
|
||
| if (!keplr) { | ||
| throw Error('Missing Keplr'); | ||
| } |
There was a problem hiding this comment.
please drop the suppression.
Suggested change
| // @ts-expect-error Check for Keplr | |
| const { keplr } = window; | |
| if (!keplr) { | |
| throw Error('Missing Keplr'); | |
| } | |
| if (!('keplr' in window)) { | |
| throw Error('Missing Keplr'); | |
| } | |
| const { keplr } = window; |
also consider a global declaration that adds keplr?: Keplr to window so it's typed.
| caption = `Agoric ${subdomain}`; | ||
| } | ||
|
|
||
| const walletUrlForStaking = `https://${url.hostname}.staking.agoric.app`; |
There was a problem hiding this comment.
this template is more of a config. please group with other such config.
|
Sorry, I enabled automerge on this mistakenly thinking it was my other pull request. I'm going to follow up right now with suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #32