-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: /save and /load saves and restores the edited-files list #1620
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Added the save/load commands
- Re-arranged the list to list frequently used commands first
- all other commands left as-is
@paul-gauthier may I ask for an indication -- can this be merged, or should I drop it? |
Thanks for your interest in aider and for taking the time to work on this PR. Unfortunately, I don't think I'll be able to merge this it. I like the concept and I know other users are interested in something like this. But the UX and implementation details in this PR probably aren't appropriate to merge. |
I appreciate the time you took to look at it. Being a recent pro dev on a large legacy project, I also appreciate that my implementation may be not suitable for this particular code base. Still, you did not say to "just drop it" -- may I ask for a word of a guidance, what can I improve about it, to make it compatible with your code, please? |
I also think this would be useful. How about if we narrowed the scope to simplify the UX? I think we get 90% of the benefit with 10% of the complexity.
This addresses the most common use case (I have a complex context but I need to narrow it temporarily so I don't confuse the LLM for a surgical edit, before continuing with the bigger project) without adding complexity around marshaling to files etc. |
What about something like |
Sorry mate, but it seems to me that overloading an existing clear-purpose command with more functionality would only worse the learning curve and what if one wanted to drop one file but accidentally did not specify a file? I know I would be annoyed by the undesired behaviour @wladimiiir I take your point of naming the save-point, but regarding at this time, load/save/drop has the simplest functionality and UX, in my humble opinion |
then you undrop, and then re-drop the one you intended (actually I would recommend using a bare |
My idea is just this simple:
While in active session |
Good thinking, I like the session proposal. |
Frequently used feature: store and load the list of editable and read-only workspace file names.