Use environment variable to check if next is handling requests #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In monorepo's with many packages, it could be that next is used in a
separate package (e.g. their website)
If we use `require.resolve("next")` it will return a path and thus start
reading bodies
For micro, there's no way to know if it's micro (`require("micro")` does not happen nor is there an env variable)
For micro, we can add a separate function handler to improve (similar to
lambda and google function).
willem-delbare
approved these changes
Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
willem-delbare
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In monorepo's with many packages, it could be that next is used in a separate package (e.g. their website)
If we use
require.resolve("next")it will return a path and thus start reading bodiesFor micro, there's no way to know if it's micro (
require("micro")does not happen nor is there an env variable)For micro, we can add a separate function handler to improve (similar to lambda and google function).