OAuth token prodiver cleanup #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyaskuti
force-pushed
the
matyaskuti/oauth_token_provider_cleanup
branch
from
d5962fb to
2934c4f
Compare
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_async_consumer
branch
from
25ec244 to
132802c
Compare
matyaskuti
force-pushed
the
matyaskuti/oauth_token_provider_cleanup
branch
from
2934c4f to
cee5073
Compare
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_async_consumer
branch
8 times, most recently
from
83e1479 to
d28d9df
Compare
matyaskuti
force-pushed
the
matyaskuti/oauth_token_provider_cleanup
branch
from
cee5073 to
c9e9e14
Compare
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_async_consumer
branch
from
d28d9df to
b17003f
Compare
Base automatically changed from
matyaskuti/confluent_kafka_async_consumer
to
main
February 15, 2024 08:36
Since we moved away from kafka-python and aiokafka based clients, there is no need to depend on either library's abstract token provider mechanism. The confluent-kafka clients take a simple callable for token fetching (pass-through in our case).
matyaskuti
force-pushed
the
matyaskuti/oauth_token_provider_cleanup
branch
from
c9e9e14 to
04ca93a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Since we moved away from kafka-python and aiokafka based clients, there is no need to depend on either library's abstract OAuth token provider mechanism. The confluent-kafka clients take a simple callable for token fetching (pass-through in our case).
Rest of the
aiokafkarelated cleanup is in #798