Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java multiple files protobuf option rendering #884

Merged

Conversation

jjaakola-aiven
Copy link
Contributor

About this change - What it does

The protobuf rendering did not change the boolean value to lowercase as expected in the IDL file.

@jjaakola-aiven jjaakola-aiven requested review from a team as code owners May 24, 2024 07:45
Copy link
Contributor

@keejon keejon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@keejon keejon merged commit d0ce5b9 into main May 24, 2024
8 checks passed
@keejon keejon deleted the jjaakola-aiven-fix-java-multiple-files-protobuf-option-rendering branch May 24, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants