rapu: catch aiohttp.ClientError with a 503 response status
#896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliax1996
reviewed
Jun 10, 2024
eliax1996
suggested changes
Jun 10, 2024
There was a problem hiding this comment.
Just asking to update the description of the pr :) the change by itself its an improvement.
Giving @jjaakola-aiven the possibility to reply on his raised point even if to me it sounds reasonable to catch both exceptions in the same scope, maybe would be useful to highlight a case where the behaviour its different and the management should be done in a different way
jjaakola-aiven
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
This catches
aiohttp.ClientErrorand returnsHTTPStatus<503>rather thanHTTPStatus<500>.We also catch the base
aiohttp.ClientErrorrather than justaiohttp.ClientConnectorError, as for us, most client errors will also be TCP connection related, rather than actual invalid request data, etc and we include the exception information with the logged message, this can further aid debugging.References: HH-3866
Why this way
Reflects properly the behaviour of the server via the response status.