Remove data-link-target attribute on anchor

Remove unnecessary data-link-target - attribute. It is not necessary anymore and can be removed. Also the support for different kinds of targets was added like _top, _self, etc. Also remove a lot of unnecessary transformation and store target with the default HTML syntax.

app/assets/javascripts/tinymce/plugins/alchemy_link/plugin.min.js

@@ -12,7 +12,7 @@ tinymce.PluginManager.add("alchemy_link", function (editor) {
       link = {
         url: anchor.href,
         title: anchor.title,
-        target: anchor.getAttribute("data-link-target"),
+        target: anchor.target,
         type: anchor.className
       }
     }
@@ -23,8 +23,7 @@ tinymce.PluginManager.add("alchemy_link", function (editor) {
         href: link.url,
         class: link.type,
         title: link.title,
-        "data-link-target": link.target,
-        target: link.target === "blank" ? "_blank" : undefined
+        target: link.target
       })
       editor.selection.collapse()
     })

app/components/alchemy/ingredients/link_view.rb

@@ -12,13 +12,7 @@ def initialize(ingredient, text: nil, html_options: {})
       end
 
       def call
-        link_to(link_text, value, {target: link_target}.merge(html_options)).html_safe
-      end
-
-      private
-
-      def link_target
-        (ingredient.link_target == "blank") ? "_blank" : nil
+        link_to(link_text, value, {target: ingredient.link_target.presence}.merge(html_options)).html_safe
       end
     end
   end

app/components/alchemy/ingredients/text_view.rb

@@ -21,8 +21,7 @@ def call
           link_to(value, url_for(link), {
             id: dom_id.presence,
             title: link_title,
-            target: ((link_target == "blank") ? "_blank" : nil),
-            data: {link_target: link_target}
+            target: link_target
           }.merge(html_options))
         end.html_safe
       end

app/models/alchemy/page.rb

@@ -271,8 +271,10 @@ def link_target_options
         options = [[Alchemy.t(:default, scope: "link_target_options"), ""]]
         link_target_options = Config.get(:link_target_options)
         link_target_options.each do |option|
+          # add an underscore to the options to provide the default syntax
+          # @link https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#target
           options << [Alchemy.t(option, scope: "link_target_options",
-            default: option.to_s.humanize), option]
+            default: option.to_s.humanize), "_#{option}"]
         end
         options
       end

spec/support/tab_examples.rb

@@ -49,7 +49,7 @@ module Alchemy
       end
 
       context "with content"
-      let(:link_target) { "blank" }
+      let(:link_target) { "_blank" }
 
       it "should have a pre-filled value" do
         expect(page.find(:css, "select[name=#{name}_link_target]").value).to eq(link_target)

spec/views/alchemy/ingredients/text_view_spec.rb

@@ -39,21 +39,21 @@
         data: {
           link: "http://google.com",
           link_title: "Foo",
-          link_target: "blank"
+          link_target: "_blank"
         }
       )
     end
 
     it "renders the linked value" do
       render ingredient
       expect(rendered).to have_content("Hello World")
-      expect(rendered).to have_selector('a[title="Foo"][target="_blank"][data-link-target="blank"][href="http://google.com"]')
+      expect(rendered).to have_selector('a[title="Foo"][target="_blank"][href="http://google.com"]')
     end
 
     context "with html_options given" do
       it "renders the linked with these options" do
         render ingredient, html_options: {title: "Bar", class: "blue"}
-        expect(rendered).to have_selector('a.blue[title="Bar"][target="_blank"][data-link-target="blank"]')
+        expect(rendered).to have_selector('a.blue[title="Bar"][target="_blank"]')
       end
     end