Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #2546

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Update README #2546

merged 2 commits into from
Aug 3, 2023

Conversation

sascha-karnatz
Copy link
Contributor

@sascha-karnatz sascha-karnatz commented Aug 2, 2023

What is this pull request for?

The supported Rails versions - section is now up to date and points to the correct branches for each Rails version. Also removed the demo section, because the demo does not work anymore.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@sascha-karnatz sascha-karnatz requested a review from a team August 2, 2023 12:35
@sascha-karnatz sascha-karnatz changed the title Update Rails version section in README Update README Aug 2, 2023
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo still works

README.md Show resolved Hide resolved
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the note about the latest stable branch to 7.0-stable as well?

The supported Rails versions - section is now up to date and points to the correct branches for each Rails version.
Heroku removed the free tier possibility. The new demo is on fly.io.
@tvdeyen tvdeyen merged commit 58b7d85 into AlchemyCMS:main Aug 3, 2023
14 checks passed
@sascha-karnatz sascha-karnatz deleted the readme-rails-version branch August 3, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants