Convert base from Coffeescript to Javascript #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-karnatz
force-pushed
the
update_javascript/move-base
branch
from
31c41ae
to
59883f3
Compare
tvdeyen
requested changes
Aug 3, 2023
sascha-karnatz
force-pushed
the
update_javascript/move-base
branch
from
becbd97
to
0b8d900
Compare
Done. I reworded the message. It was an old commit, that I cherry picked. |
tvdeyen
requested changes
Aug 25, 2023
sascha-karnatz
force-pushed
the
update_javascript/move-base
branch
from
0b8d900
to
3ec1b2c
Compare
tvdeyen
requested changes
Aug 28, 2023
sascha-karnatz
force-pushed
the
update_javascript/move-base
branch
3 times, most recently
from
b10fbe0
to
704f0c3
Compare
sascha-karnatz
force-pushed
the
update_javascript/move-base
branch
from
704f0c3
to
dfea032
Compare
Also move file to app/javascript - folder.
Create a javascript file for each function. They are not related to each other.
try to reduce the jQuery usage and migrate the picture selector section from jQuery to vanilla Javascript.
The overlay is now a web component and a bit easier to use. The API is still the same, but the component is using the same mechanic as the Spinner.
sascha-karnatz
force-pushed
the
update_javascript/move-base
branch
from
dfea032
to
e28a6ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Also move file to app/javascript - folder. Remove getUrlParam - method because it isn't used anywhere.
Checklist