Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Proposal: A resource table component #2785

Closed

Conversation

kulturbande
Copy link
Contributor

What is this pull request for?

Add an experimental resource table component. The idea is to make it easier to create resource tables without duplicating the table structure and be in sync between the index view and the row partial.

Screenshots

An example:
CleanShot 2024-03-09 at 16 00 32@2x

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@kulturbande kulturbande requested a review from a team as a code owner March 9, 2024 15:03
@kulturbande kulturbande marked this pull request as draft March 9, 2024 15:03
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.91%. Comparing base (8175627) to head (e353cff).
Report is 28 commits behind head on main.

Files Patch % Lines
app/components/alchemy/admin/resource/table.rb 95.55% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2785      +/-   ##
==========================================
+ Coverage   95.90%   95.91%   +0.01%     
==========================================
  Files         225      226       +1     
  Lines        6103     6173      +70     
==========================================
+ Hits         5853     5921      +68     
- Misses        250      252       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kulturbande kulturbande force-pushed the resource-table-component branch 3 times, most recently from ce62208 to 056fb9e Compare March 10, 2024 09:33
@kulturbande kulturbande force-pushed the resource-table-component branch 4 times, most recently from fc5ea3b to 27e6f07 Compare April 1, 2024 20:39
Add first try of a resource table. It is pretty raw and does not create the right output, but it is only a proposal.
@kulturbande
Copy link
Contributor Author

Maybe we need a bigger approach in creating REST - Interfaces in Alchemy. I will close the pull request for now.

@kulturbande
Copy link
Contributor Author

I had a change of mind and try it again

@kulturbande kulturbande mentioned this pull request Jul 21, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant