Skip to content

Commit

Permalink
temp workaround for wrong rates in ConvolutionSparseLayer/Convolution…
Browse files Browse the repository at this point in the history
…PointwiseSparseLayer, was causing mismatch between partition and layer interval. todo: move part of its latency function to the rate calculation instead!
  • Loading branch information
Yu-Zhewen committed Mar 4, 2024
1 parent 30d0b39 commit 12307d5
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions fpgaconvnet/models/partition/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,9 @@ def get_interval(self):
the partition.
"""
# get the interval matrix
interval_matrix = matrix.get_interval_matrix(self.graph)
# return the overall interval
return np.max(np.absolute(interval_matrix))

interval = max([self.graph.nodes[node]['hw'].latency() for node in self.graph])
return interval

def get_cycle(self):
# get the interval for the partition
interval = self.get_interval()
Expand Down

1 comment on commit 12307d5

@AlexMontgomerie
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yu-Zhewen I think we should keep this for interval estimation. I don't think the matrix method is actually needed

Please sign in to comment.