SonarCloud fixes (#4235)

Alfresco · Nov 13, 2024 · 90ca370 · 90ca370
1 parent 27e318a
commit 90ca370
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 10 deletions.
diff --git a/projects/aca-content/folder-rules/src/rule-details/validators/rule-actions.validator.ts b/projects/aca-content/folder-rules/src/rule-details/validators/rule-actions.validator.ts
@@ -37,8 +37,7 @@ const isRuleActionValid = (value: unknown, actionDefinitions: ActionDefinitionTr
     : undefined;
   return (
     isRuleAction(value) &&
-    actionDefinition &&
-    actionDefinition.parameterDefinitions.reduce(
+    actionDefinition?.parameterDefinitions.reduce(
       (isValid: boolean, paramDef: ActionParameterDefinitionTransformed) => isValid && (!paramDef.mandatory || !!value.params[paramDef.name]),
       true
     )

diff --git a/projects/aca-content/folder-rules/src/services/folder-rule-sets.service.ts b/projects/aca-content/folder-rules/src/services/folder-rule-sets.service.ts
@@ -37,7 +37,7 @@ import { Rule } from '../model/rule.model';
   providedIn: 'root'
 })
 export class FolderRuleSetsService {
-  public static MAX_RULE_SETS_PER_GET = 100;
+  public static readonly MAX_RULE_SETS_PER_GET = 100;
 
   static isOwnedRuleSet(ruleSet: RuleSet, nodeId: string): boolean {
     return ruleSet?.owningFolder?.id === nodeId;

diff --git a/projects/aca-content/folder-rules/src/services/folder-rules.service.ts b/projects/aca-content/folder-rules/src/services/folder-rules.service.ts
@@ -40,7 +40,7 @@ interface GetRulesResult {
   providedIn: 'root'
 })
 export class FolderRulesService {
-  public static MAX_RULES_PER_GET = 100;
+  public static readonly MAX_RULES_PER_GET = 100;
 
   public static get emptyCompositeCondition(): RuleCompositeCondition {
     return {

diff --git a/projects/aca-content/src/lib/components/common/location-link/location-link.component.ts b/projects/aca-content/src/lib/components/common/location-link/location-link.component.ts
@@ -83,7 +83,7 @@ export class LocationLinkComponent implements OnInit {
   ngOnInit() {
     if (this.context) {
       const node: NodeEntry = this.context.row.node;
-      if (node?.entry && node?.entry?.path) {
+      if (node?.entry?.path) {
         const path = node.entry.path;
 
         if (path?.name && path?.elements) {

diff --git a/projects/aca-playwright-shared/src/utils/utils.ts b/projects/aca-playwright-shared/src/utils/utils.ts
@@ -30,8 +30,8 @@ import StreamZip from 'node-stream-zip';
 import { NodesApi, SitesApi, TrashcanApi } from '../api';
 
 export class Utils {
-  static string257Long = 'x'.repeat(257);
-  static string513Long = 'x'.repeat(513);
+  static readonly string257Long = 'x'.repeat(257);
+  static readonly string513Long = 'x'.repeat(513);
 
   static random(): string {
     return crypto.getRandomValues(new Uint32Array(1))[0].toString(36).substring(0, 5).toLowerCase();

diff --git a/projects/aca-shared/src/lib/services/node-permission.service.ts b/projects/aca-shared/src/lib/services/node-permission.service.ts
@@ -37,7 +37,7 @@ export interface PermissionOptions {
   providedIn: 'root'
 })
 export class NodePermissionService implements NodePermissions {
-  static DEFAULT_OPERATION = 'OR';
+  static readonly DEFAULT_OPERATION = 'OR';
 
   private defaultOptions: PermissionOptions = {
     operation: NodePermissionService.DEFAULT_OPERATION,

diff --git a/scripts/gh/update/latest-version-of.js b/scripts/gh/update/latest-version-of.js
@@ -34,12 +34,12 @@ module.exports = async ({ exec, github, dependencyName, tag }) => {
     }
   }
 
-  const latestPkgToUpdate = availablePackages.find((package) => package.name === matchedPkgVersion);
+  const latestPkgToUpdate = availablePackages.find((pkg) => pkg.name === matchedPkgVersion);
 
   if (localVersion === latestPkgToUpdate?.name) {
     return { hasNewVersion: 'false' };
   } else {
-    const findLocalVersionOnRemote = availablePackages.find((package) => package.name === localVersion);
+    const findLocalVersionOnRemote = availablePackages.find((pkg) => pkg.name === localVersion);
     let rangeInDays = 'N/A';
     if (findLocalVersionOnRemote !== undefined) {
       const creationLocal = new Date(findLocalVersionOnRemote.created_at);