[ACS-8645][Legal Hold] ACA - context menu - hide unnecessary options #4064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamaragruszka
requested review from
AleksanderSklorz,
DaryaBalvanovich,
DenysVuika and
MichalKinas
jacekpluta
approved these changes
Aug 28, 2024
dominikiwanekhyland
approved these changes
Aug 28, 2024
tamaragruszka
changed the title
swapnil-verma-gl
approved these changes
Aug 29, 2024
DenysVuika
reviewed
Aug 29, 2024
| @@ -27,6 +27,7 @@ import { RuleContext } from '@alfresco/adf-extensions'; | |||
| import * as navigation from './navigation.rules'; | |||
| import * as repository from './repository.rules'; | |||
| import { isAdmin } from './user.rules'; | |||
| import { NodeEntry } from '@alfresco/js-api/typings'; | |||
There was a problem hiding this comment.
should not have '/typings' in the import
MichalKinas
requested changes
Aug 30, 2024
| @@ -629,3 +631,5 @@ export function isSmartFolder(context: RuleContext): boolean { | |||
| export const areTagsEnabled = (context: AcaRuleContext): boolean => context.appConfig.get('plugins.tagsEnabled', true); | |||
|
|
|||
| export const areCategoriesEnabled = (context: AcaRuleContext): boolean => context.appConfig.get('plugins.categoriesEnabled', true); | |||
|
|
|||
| export const isNodeFrozen = (_context: RuleContext, node: NodeEntry): boolean => !!node?.entry?.properties?.['rma:frozenAt']; | |||
There was a problem hiding this comment.
This aspect should only be available from governance, this rule should not be placed in ACA
…-unnecessary-options
…-unnecessary-options
…-unnecessary-options
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-8645
What is the new behaviour?
most options are hidden for files on hold
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: