Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-9158] Remove 'View Details' button from node Details page #4351

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nikita-web-ua
Copy link
Contributor

https://hyland.atlassian.net/browse/ACS-9158

The "View Details" button has been removed from the Details page because the button's logic causes the page to redirect on refresh and the link cannot be accessed directly. At the same time "Reduce panel" button is retained and performs the same action.

Screenshot 2025-01-22 at 09 41 16

@nikita-web-ua nikita-web-ua marked this pull request as ready for review January 22, 2025 13:07
@@ -461,7 +461,7 @@ export const canToggleSharedLink = (context: RuleContext): boolean =>
* @param context Rule execution context
*/
export const canShowInfoDrawer = (context: RuleContext): boolean =>
[hasSelection(context), navigation.isNotLibraries(context), navigation.isNotTrashcan(context)].every(Boolean);
[hasSelection(context), navigation.isNotLibraries(context), navigation.isNotTrashcan(context), navigation.isNotDetails(context)].every(Boolean);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the context of the visibility rules PR, the canShowInfoDrawer rule and method will be removed in favour of individual array based rules. So the reference of this rule in app.extensions.json at line num 498 and 1057 will no longer be present once that PR is merged, and would be replaced with separate arrays as can be seen in that PR. Can you please update the code here so that instead of adding the navigation.isNotDetails(context) call here, its added as an element of the visible array in the json file itself. I see that this rule is already registered in aca-content.module.ts in this PR, so you only need to modify the rule in the json. The change should be something similar to

"visible": [ "canShowInfoDrawer", "app.navigation.isNotDetails" ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants