-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-8215] Filter out dependencies of dependencies in licenses.ts script #10241
base: develop
Are you sure you want to change the base?
Conversation
f7cebf3
to
5b4495a
Compare
Quality Gate passedIssues Measures |
pack['repository'] = missingRepositories[mainName]; | ||
} | ||
|
||
const lastAtSignPos = packageName.lastIndexOf('@'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you had a chance to test those changes? And if so how did you test it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I can't support this ticket anymore that's why I asked @MateuszHY to double check with someone who can take care and retest it. Also you can talk with @eromano about running scripts
I changed node_modules/@alfresco/adf-cli/scripts/licenses.js
then run scripts/release.sh
and see output.
After I checked that it works correctly (creates new file with 38 dependencies lines) I applied these changes to lib/cli/scripts/licenses.ts
.
Also you can check with node dist/libs/cli/scripts/licenses.js
command
JIRA ticket: https://hyland.atlassian.net/browse/ACS-8215
Script omits child dependencies of any top-level library.