Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-8215] Filter out dependencies of dependencies in licenses.ts script #10241

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

tomson7777
Copy link
Contributor

JIRA ticket: https://hyland.atlassian.net/browse/ACS-8215

Script omits child dependencies of any top-level library.

@tomson7777 tomson7777 force-pushed the ACS-8215-filter-out-deps-of-deps branch from f7cebf3 to 5b4495a Compare October 4, 2024 13:19
Copy link

sonarcloud bot commented Oct 22, 2024

pack['repository'] = missingRepositories[mainName];
}

const lastAtSignPos = packageName.lastIndexOf('@');
Copy link
Contributor

@MichalKinas MichalKinas Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you had a chance to test those changes? And if so how did you test it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I can't support this ticket anymore that's why I asked @MateuszHY to double check with someone who can take care and retest it. Also you can talk with @eromano about running scripts

I changed node_modules/@alfresco/adf-cli/scripts/licenses.js then run scripts/release.sh and see output.
After I checked that it works correctly (creates new file with 38 dependencies lines) I applied these changes to lib/cli/scripts/licenses.ts.
Also you can check with node dist/libs/cli/scripts/licenses.js command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants