Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for Pydantic 1/2 #42

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Add testing for Pydantic 1/2 #42

merged 5 commits into from
Nov 14, 2023

Conversation

cthoyt
Copy link
Collaborator

@cthoyt cthoyt commented Nov 3, 2023

This PR adds to the testing framework checks for compatibility with both Pydantic 1 and 2

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (53b161d) 87.07% compared to head (25b9c5d) 87.38%.

❗ Current head 25b9c5d differs from pull request most recent head c9bb681. Consider uploading reports for the commit c9bb681 to get more accurate results

Files Patch % Lines
src/acsets/acsets.py 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   87.07%   87.38%   +0.30%     
==========================================
  Files           6        6              
  Lines         325      325              
  Branches       54       54              
==========================================
+ Hits          283      284       +1     
  Misses         36       36              
+ Partials        6        5       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olynch
Copy link
Member

olynch commented Nov 7, 2023

Let's figure out why the documentation is failing here, and then get this merged.

@olynch olynch marked this pull request as ready for review November 14, 2023 23:46
@olynch
Copy link
Member

olynch commented Nov 14, 2023

Going to merge this even if the doc-test is failing, because the documentation still builds.

@olynch olynch merged commit 45e5b2e into main Nov 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants