Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPC/calibration: Add standalone dEdx calculation class #11663

Merged
merged 14 commits into from
Aug 18, 2023
Merged

TPC/calibration: Add standalone dEdx calculation class #11663

merged 14 commits into from
Aug 18, 2023

Conversation

tubagundem
Copy link
Contributor

No description provided.

@tubagundem tubagundem marked this pull request as ready for review July 25, 2023 07:14
davidrohr
davidrohr previously approved these changes Jul 25, 2023
View reviewed changes
@tubagundem tubagundem marked this pull request as draft July 28, 2023 13:16
wiechula
wiechula requested changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@wiechula wiechula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Just some minor things.

Detectors/TPC/calibration/src/CalculatedEdx.cxx Outdated Show resolved Hide resolved
Detectors/TPC/calibration/include/TPCCalibration/CalculatedEdx.h Outdated Show resolved Hide resolved
Detectors/TPC/calibration/src/CalculatedEdx.cxx Outdated Show resolved Hide resolved
Detectors/TPC/calibration/src/CalculatedEdx.cxx Outdated Show resolved Hide resolved
Detectors/TPC/calibration/src/CalculatedEdx.cxx Outdated Show resolved Hide resolved
Detectors/TPC/calibration/src/CalculatedEdx.cxx Outdated Show resolved Hide resolved
wiechula
wiechula previously approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@wiechula wiechula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Looks fine so far.

@wiechula wiechula marked this pull request as ready for review August 10, 2023 14:34
@wiechula
Copy link
Collaborator

@tubagundem , please check the clang-format issues and squash your changes.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for cde5676 at 2023-08-13 11:48:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/11663-slc8_x86-64/0/Detectors/TPC/monitor/src/SimpleEventDisplayGUI.cxx:185:48: error: redundant void argument list in function definition [modernize-redundant-void-arg]
/sw/SOURCES/O2/11663-slc8_x86-64/0/Detectors/TPC/monitor/src/SimpleEventDisplayGUI.cxx:245:50: error: redundant void argument list in function definition [modernize-redundant-void-arg]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@davidrohr
Copy link
Collaborator

davidrohr commented Aug 14, 2023 •
edited
Loading

@wiechula : If you could approve the final PR, I'll squah-merge once the CI is green.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 846d639 at 2023-08-14 08:57:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep ' error:'
++ grep -v clang-diagnostic-error error-log.txt
/sw/SOURCES/O2/11663-slc8_x86-64/0/Detectors/TPC/monitor/src/SimpleEventDisplayGUI.cxx:185:48: error: redundant void argument list in function definition [modernize-redundant-void-arg]
/sw/SOURCES/O2/11663-slc8_x86-64/0/Detectors/TPC/monitor/src/SimpleEventDisplayGUI.cxx:245:50: error: redundant void argument list in function definition [modernize-redundant-void-arg]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@sawenzel sawenzel merged commit d4fa0d5 into AliceO2Group:dev Aug 18, 2023
6 checks passed
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Aug 24, 2023
@tubagundem @mwinn2
TPC/calibration: Add standalone dEdx calculation class (AliceO2Group#…
48c13a6 
…11663)

*  Add dEdx calculation class
nbize pushed a commit to nbize/AliceO2 that referenced this pull request Aug 31, 2023
@tubagundem @nbize
TPC/calibration: Add standalone dEdx calculation class (AliceO2Group#…
ccc66a5 
…11663)

*  Add dEdx calculation class
@tubagundem tubagundem deleted the TPC_dEdx_Calculation branch September 12, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiechula wiechula wiechula approved these changes

@davidrohr davidrohr davidrohr left review comments

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tubagundem @wiechula @alibuild @davidrohr @sawenzel