-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TPC: Feature/o2 monitor occupancy #11745
Merged
shahor02
merged 4 commits into
AliceO2Group:dev
from
sidibu:feature/o2-monitor-occupancy
Aug 11, 2023
Merged
TPC: Feature/o2 monitor occupancy #11745
shahor02
merged 4 commits into
AliceO2Group:dev
from
sidibu:feature/o2-monitor-occupancy
Aug 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a signal treshold value to the TPC O2 monitor. Using the threshold, only signals greater or equal to the threshold will be shown on the monitor.
Implemented the possibility to plot the occupancy of the given signals for the O2 monitor.
wiechula
changed the title
Feature/o2 monitor occupancy
TPC: Feature/o2 monitor occupancy
Aug 10, 2023
wiechula
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks fine!
can this be merged? |
@ktf There is something wrong with the fullCI.
have become errors in the fullCI runs in other PRs (see #11746):
|
sidibu
added a commit
to sidibu/AliceO2
that referenced
this pull request
Aug 16, 2023
* Add Signal Value Threshold Added a signal treshold value to the TPC O2 monitor. Using the threshold, only signals greater or equal to the threshold will be shown on the monitor. * Add Occupancy Inspection Implemented the possibility to plot the occupancy of the given signals for the O2 monitor. * Fixed Formatting * Implemented suggested changes
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Aug 24, 2023
* Add Signal Value Threshold Added a signal treshold value to the TPC O2 monitor. Using the threshold, only signals greater or equal to the threshold will be shown on the monitor. * Add Occupancy Inspection Implemented the possibility to plot the occupancy of the given signals for the O2 monitor. * Fixed Formatting * Implemented suggested changes
nbize
pushed a commit
to nbize/AliceO2
that referenced
this pull request
Aug 31, 2023
* Add Signal Value Threshold Added a signal treshold value to the TPC O2 monitor. Using the threshold, only signals greater or equal to the threshold will be shown on the monitor. * Add Occupancy Inspection Implemented the possibility to plot the occupancy of the given signals for the O2 monitor. * Fixed Formatting * Implemented suggested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the possibility to set a value threshold for the O2 monitor as well as plotting the occupancy for the given signals @wiechula.