Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPC: Feature/o2 monitor occupancy #11745

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

sidibu
Copy link
Contributor

@sidibu sidibu commented Aug 9, 2023

Implemented the possibility to set a value threshold for the O2 monitor as well as plotting the occupancy for the given signals @wiechula.

Added a signal treshold value to the TPC O2 monitor. Using the threshold, only signals greater or equal to the threshold will be shown on the monitor.
Implemented the possibility to plot the occupancy of the given signals for the O2 monitor.
@wiechula wiechula changed the title Feature/o2 monitor occupancy TPC: Feature/o2 monitor occupancy Aug 10, 2023
Copy link
Collaborator

@wiechula wiechula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks fine!

@wiechula
Copy link
Collaborator

can this be merged?

@shahor02 shahor02 merged commit a43da90 into AliceO2Group:dev Aug 11, 2023
6 checks passed
@vkucera
Copy link
Collaborator

vkucera commented Aug 11, 2023

@ktf There is something wrong with the fullCI.
These warnings triggered by the changes in this PR

/sw/SOURCES/O2/11745-slc8_x86-64/0/Detectors/TPC/monitor/src/SimpleEventDisplayGUI.cxx:185:48: warning: redundant void argument list in function definition [modernize-redundant-void-arg]
void SimpleEventDisplayGUI::initOccupancyHists(void)
                                               ^~~~
/sw/SOURCES/O2/11745-slc8_x86-64/0/Detectors/TPC/monitor/src/SimpleEventDisplayGUI.cxx:245:50: warning: redundant void argument list in function definition [modernize-redundant-void-arg]
void SimpleEventDisplayGUI::deleteOccupancyHists(void)
                                                 ^~~~

have become errors in the fullCI runs in other PRs (see #11746):


/sw/SOURCES/O2/11746-slc8_x86-64/0/Detectors/TPC/monitor/src/SimpleEventDisplayGUI.cxx:185:48: error: redundant void argument list in function definition [modernize-redundant-void-arg]
/sw/SOURCES/O2/11746-slc8_x86-64/0/Detectors/TPC/monitor/src/SimpleEventDisplayGUI.cxx:245:50: error: redundant void argument list in function definition [modernize-redundant-void-arg]

sidibu added a commit to sidibu/AliceO2 that referenced this pull request Aug 16, 2023
* Add Signal Value Threshold

Added a signal treshold value to the TPC O2 monitor. Using the threshold, only signals greater or equal to the threshold will be shown on the monitor.

* Add Occupancy Inspection

Implemented the possibility to plot the occupancy of the given signals for the O2 monitor.

* Fixed Formatting

* Implemented suggested changes
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Aug 24, 2023
* Add Signal Value Threshold

Added a signal treshold value to the TPC O2 monitor. Using the threshold, only signals greater or equal to the threshold will be shown on the monitor.

* Add Occupancy Inspection

Implemented the possibility to plot the occupancy of the given signals for the O2 monitor.

* Fixed Formatting

* Implemented suggested changes
nbize pushed a commit to nbize/AliceO2 that referenced this pull request Aug 31, 2023
* Add Signal Value Threshold

Added a signal treshold value to the TPC O2 monitor. Using the threshold, only signals greater or equal to the threshold will be shown on the monitor.

* Add Occupancy Inspection

Implemented the possibility to plot the occupancy of the given signals for the O2 monitor.

* Fixed Formatting

* Implemented suggested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants