Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "DPL Analysis: make BindingNodes constexpr" #12673

Closed
wants to merge 1 commit into from

Conversation

martenole
Copy link
Contributor

Reverts #12661

Hi @ktf and @aalkin would you be OK to revert this? It is requires c++20 features which we don't yet have employed at P2 and therefore our daily builds are failing, e.g. https://alijenkins.cern.ch/job/DailyBuilds/job/DailyO2epn/1252/console
Next week's FLP suite should contain the bump of the O2 defaults and then this could be merged

@martenole martenole requested a review from a team as a code owner February 8, 2024 10:25
@ktf
Copy link
Member

ktf commented Feb 8, 2024

In principle we can make this work with both after lunch. Would that work?

@aalkin
Copy link
Member

aalkin commented Feb 8, 2024

#12674 works both for 20 and 17

@alibuild
Copy link
Collaborator

alibuild commented Feb 8, 2024

Error while checking build/O2/fullCI for b53fd0d at 2024-02-08 12:27:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/12673-slc8_x86-64/0/Framework/DataInspector/src/DataInspectorService.cxx:208:11: error: namespace 'o2::framework::DataInspector' does not follow the underscore convention [aliceO2-namespace-naming]
/sw/SOURCES/O2/12673-slc8_x86-64/0/Framework/DataInspector/src/DataInspectorService.cxx:241:36: error: namespace 'o2::framework::DataInspector' does not follow the underscore convention [aliceO2-namespace-naming]
/sw/SOURCES/O2/12673-slc8_x86-64/0/Framework/DataInspector/src/DataInspector.cxx:47:26: error: namespace 'o2::framework::DataInspector' does not follow the underscore convention [aliceO2-namespace-naming]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@martenole
Copy link
Contributor Author

Thanks! Then I'll close this in favor of #12674

@martenole martenole closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants