Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU: Add prototype for SMatrixGPU testing #12693

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

mconcas
Copy link
Collaborator

@mconcas mconcas commented Feb 12, 2024

As anticipated at the last FST/GPU meeting, a student will advance in porting and testing the DCAFitterN class on GPU.
To this extent, I ported (3 years ago) an SVector and SMatrix implementation from ROOT to a usable GPU version.

I am now adding the skeleton of a unit test (CUDA/HIP) to ensure the required functions (the ones used in the fitter class) work.
For the moment, I added the inversion test of a simple 3x3 symmetric matrix as a test.

The student will then be responsible for extending this test by adding the required methods.

I expect the FullCI to fail since no GPU is available. It will probably require some massage in alidist as it is done for the GPU sort test.

@mconcas mconcas requested review from davidrohr, shahor02 and a team as code owners February 12, 2024 22:52
@mconcas mconcas force-pushed the pr-add-SMatrix-test branch 2 times, most recently from 5eecd81 to f4175f1 Compare February 12, 2024 22:58
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for f4175f1 at 2024-02-13 00:46:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/12693-slc8_x86-64/0/GPU/Common/test/testSMatrixImp.hip:109:3: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@davidrohr
Copy link
Collaborator

fine with me after coding violation is fixed

@mconcas
Copy link
Collaborator Author

mconcas commented Feb 13, 2024

fine with me after coding violation is fixed

ok, then it's ready

@mconcas mconcas merged commit 5ed529c into AliceO2Group:dev Feb 13, 2024
12 checks passed
@mconcas mconcas deleted the pr-add-SMatrix-test branch February 13, 2024 14:02
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
* Add HIPIFIED tests

* Finalise inversion test
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
* Add HIPIFIED tests

* Finalise inversion test
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
* Add HIPIFIED tests

* Finalise inversion test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants