Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCTRL-928] Add kafka event for DCS SOR state SOR_PROGRESSING #616

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

justonedev1
Copy link
Collaborator

Added kafka message to DCS for any detector change for any detector

@justonedev1
Copy link
Collaborator Author

Just for the record, I absolutely hate that we don't have any helper functions to send/log data around ECS, because the result is that we have too much code doing nothing except logging/sending kafka message. This code 90% copied around and only some small things are changed and thus it is really hard to find what is the difference between these calls.....

Copy link
Collaborator

@knopers8 knopers8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree about the boilerplate... I'm not sure what to do about it exactly, but let's think about it.

@knopers8 knopers8 merged commit ed1bbff into master Sep 25, 2024
2 checks passed
@knopers8 knopers8 deleted the OCTRL-928 branch September 25, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants