Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddsched plugin gRPC calls have timeout by default #624

Merged
merged 1 commit into from
Oct 22, 2024
Merged

ddsched plugin gRPC calls have timeout by default #624

merged 1 commit into from
Oct 22, 2024

Conversation

justonedev1
Copy link
Collaborator

I did this as a proposal, how to add gRPC timeout to all calls in one plugin by default. However I am not sure whether this is desirable, because I found multiple TIMEOUTS in ddsched plugin, some of them are not even used. So I would like to ask @teo what do you think about this.

@justonedev1 justonedev1 requested a review from teo October 18, 2024 17:08
core/config.go Outdated Show resolved Hide resolved
@teo
Copy link
Member

teo commented Oct 21, 2024

I did this as a proposal, how to add gRPC timeout to all calls in one plugin by default. However I am not sure whether this is desirable, because I found multiple TIMEOUTS in ddsched plugin, some of them are not even used. So I would like to ask @teo what do you think about this.

I agree with this in principle. ddsched is specific because we have to poll for op completion, but the client-side timeout is still missing. Concerning the unused timeout constants, it could be they were planned but never materialized, or were used in a previous version (likely the former).

@justonedev1 justonedev1 force-pushed the OCTRL-942 branch 2 times, most recently from 6455cbe to 0a24a72 Compare October 22, 2024 09:55
@justonedev1 justonedev1 marked this pull request as ready for review October 22, 2024 10:14
@justonedev1 justonedev1 requested a review from teo October 22, 2024 10:14
@teo teo merged commit b14ce6b into master Oct 22, 2024
2 checks passed
@teo teo deleted the OCTRL-942 branch October 22, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants