Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asyn-label workflows for PRs #1489

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

benedikt-voelkel
Copy link
Contributor

Following what was introduced in alisw/ali-bot#1293

@benedikt-voelkel
Copy link
Contributor Author

@TimoWilken what do you think?
I hope I did everything correctly

@benedikt-voelkel
Copy link
Contributor Author

ok, I got something with the permissions wrong. Let me check

@TimoWilken
Copy link
Contributor

I think you may need to add the pull-requests: write permission to the top-level permissions block as well, not just the jobs block!

@TimoWilken
Copy link
Contributor

Hm, I'm not sure, maybe you need issues: write as well? But then I don't know why it worked before...

@benedikt-voelkel
Copy link
Contributor Author

+async-label async-2022-pp-apass4

@benedikt-voelkel
Copy link
Contributor Author

benedikt-voelkel commented Feb 23, 2024

Is it because it is run from my PR and not from upstream?

Because I do understand why the adding does not work. on: issue_comment only works when the wf is on the default branch already

@benedikt-voelkel
Copy link
Contributor Author

Merge to see if things work once they are in the upstream repo

@benedikt-voelkel benedikt-voelkel merged commit 045895f into AliceO2Group:master Feb 23, 2024
8 of 9 checks passed
@benedikt-voelkel benedikt-voelkel deleted the async-labels branch February 23, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants