[QC-1201] Consider replacing the merged object with the input if it has higher run number #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopers8
reviewed
Sep 30, 2024
| << ENDM; | ||
| reportedMismatchingRunNumbers = true; | ||
| otherMO->Copy(*targetMO); |
There was a problem hiding this comment.
regarding the Copy, yes, i think this is the way.
| @@ -46,16 +45,19 @@ void MonitorObjectCollection::merge(mergers::MergeInterface* const other) | |||
| if (!otherMO || !targetMO) { | |||
| throw std::runtime_error("The target object or the other object could not be casted to MonitorObject."); | |||
| } | |||
| if (!reportedMismatchingRunNumbers && targetMO->getActivity().mId != otherMO->getActivity().mId) { | |||
|
|
|||
| if (otherMO->getActivity().mId > targetMO->getActivity().mId) { | |||
There was a problem hiding this comment.
yes, but we should still produce a warning and ignore an input object if it's run number is lower, and as before, avoid flooding the IL for the rest of otherCollection. In this version of the code, you would simply merge such input anyway.
| << targetMO->GetName() << "' (" << targetMO->getActivity().mId | ||
| << "). Trying to continue, but THIS SHOULD BE IMMEDIATELY ADDRESSED IN PRODUCTION. " | ||
| << "QC objects from other setups are reaching this one. Will not report more mismatches in this collection." | ||
| << "). I am switching these objects, but THIS SHOULD BE IMMEDIATELY ADDRESSED IN PRODUCTION. " |
There was a problem hiding this comment.
"I am switching these objects" is not clear to me, how about "Replacing the merged object with input"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is this the way how to do the ticket goal correctly? I have yet to add tests, so I am making draft first, so you can tell me if this is not it