Deep cleanup 🧹 (#138)

app/application.js

@@ -62,7 +62,6 @@ class RunConditionTableApplication {
         httpServer.post(EP.logout, (req, res) => databaseService.logoutSession(req, res));
         httpServer.get(EP.rctData, (req, res) => databaseService.pgExecFetchData(req, res));
         httpServer.post(EP.insertData, (req, res) => databaseService.pgExecDataInsert(req, res));
-        httpServer.get(EP.date, (req, res) => databaseService.getDate(req, res));
         httpServer.get(EP.sync, async (_req, _res) => this.syncManager.syncAll());
     }
 

app/config/public.js

@@ -29,7 +29,6 @@ module.exports = { // Properties that will be provided to frontend in the public
         rctData: '/RCT-Data/',
         insertData: '/Rct-Data/insert-data/',
         authControl: '/auth-control/',
-        date: '/date/',
         sync: '/sync/',
     },
     methods: {

app/public/model/navigation/Navigation.js

@@ -58,8 +58,6 @@ export default class Navigation extends Observable {
                 }
                 break;
             }
-            case '/admin/':
-                throw 'TODO';
             default:
                 break;
         }

app/public/styles/custom.less

@@ -12,6 +12,13 @@
  * or submit itself to any jurisdiction.
  */
 
+.panel {
+    justify-content: center;
+    display: flex;
+    flex-direction: column;
+    align-items: center;
+}
+
 .font-size-small {
     font-size: small !important;
 }

app/public/styles/ehevi/custom/input/form.css

@@ -26,22 +26,3 @@
     padding-top: 0px;
     height: 50px;
 }
-
-.ehevi .loginButton {
-    color: var(--color-white) !important;
-    font-weight: bolder;
-    background-color: #1e90ff !important;
-}
-
-.ehevi .loginFormInput {
-    background-color: var(--color-gray-light);
-    width: 100%;
-    height: 32px;
-    border: none;
-    border-radius: 5px;
-    text-indent: 34px;
-}
-
-.ehevi .loginFormInput:focus {
-    background-color: var(--active-color);
-}

app/public/styles/ehevi/index.less

@@ -20,7 +20,6 @@
 @import (less) "./custom/components/run-quality.css";
 @import (less) "./custom/components/sidebar.css";
 @import (less) "./custom/components/snackbar.css";
-@import (less) "./custom/components/tooltip.css";
 @import (less) "./custom/filter/filter.css";
 @import (less) "./custom/input/form.css";
 @import (less) "./custom/input/select.css";
@@ -73,11 +72,3 @@
     .justify-center;
 }
 
-.loginForm {
-    .flex-column;
-    .p4;
-    .abs-center;
-    background-color: var(--off-white);
-    box-shadow:0 0 15px 4px rgba(0,0,0,0.06);
-    border-radius: 20px;
-}

app/public/view.js

@@ -17,22 +17,11 @@ import serviceUnavailablePanel from './views/serviceUnavailableView.js';
 import sessionErrorPanel from './views/sessionErrorView.js';
 import waitingPanel from './views/waitingView.js';
 import { switchCase } from '/js/src/index.js';
-import loginForm from './views/loginForm.js';
-import modal from './components/common/modal.js';
-import { h } from '/js/src/index.js';
-
-export const adminLoginModalId = 'adminLoginModal';
 
 export default function view(model) {
-    return h('',
-        modal(loginForm(model), adminLoginModalId),
-        switchCase(model.mode, {
-            serviceUnavailable: () => serviceUnavailablePanel(model),
-            sessionError: () => sessionErrorPanel(model),
-            dataAccess: () => userPanel(model),
-            admin: () => {
-                document.getElementById(adminLoginModalId).style.display = 'block';
-                return '';
-            },
-        }, () => waitingPanel())());
+    return switchCase(model.mode, {
+        serviceUnavailable: () => serviceUnavailablePanel(model),
+        sessionError: () => sessionErrorPanel(model),
+        dataAccess: () => userPanel(model),
+    }, () => waitingPanel())();
 }

app/public/views/userView/data/dataPanel.js

@@ -14,7 +14,7 @@
 
 import { h } from '/js/src/index.js';
 import tablePanel from './table/tablePanel.js';
-import spinnerAndReloadView from './fetchingStates/loading.js';
+import loading from './fetchingStates/loading.js';
 import failureStatusAndReload from './fetchingStates/failure.js';
 import unknownError from './fetchingStates/unknown.js';
 import { RCT } from '../../../config.js';
@@ -34,7 +34,7 @@ export default function dataPanel(model, runs, detectors, flags) {
 
     return data ? data.match({
         NotAsked: () => h('', 'not asked'),
-        Loading: () => spinnerAndReloadView(model),
+        Loading: () => loading(),
         Success: () => {
             switch (page) {
                 case pageNames.flags:

app/public/views/userView/data/fetchingStates/loading.js

@@ -13,87 +13,18 @@
  */
 
 import { h } from '/js/src/index.js';
-import viewButton from '../../../../components/common/viewButton.js';
 import spinner from '../../../../components/common/spinner.js';
 
-const pos = { x: 0, y: 0 };
-
-const saveCursorPosition = (x, y) => {
-    pos.x = (x / window.innerWidth).toFixed(2);
-    pos.y = (y / window.innerHeight).toFixed(2);
-    document.documentElement.style.setProperty('--x', pos.x);
-    document.documentElement.style.setProperty('--y', pos.y);
-};
-
-export default function spinnerAndReloadView(model) {
-    const loadingFinished = () => model.fetchedData[model.getCurrentDataPointer().page][model.getCurrentDataPointer().index]?.kind !== 'Loading';
-    let totalSeconds = 0;
-    let counterId = undefined;
-
-    const initCounter = () => {
-        if (counterId !== undefined) {
-            clearInterval(counterId);
-            counterId = undefined;
-            totalSeconds = 0;
-        }
-        if (counterId === undefined) {
-            counterId = setInterval(setTime, 1000);
-        }
-    };
-
-    const setTime = () => {
-        let minutesLabel = null;
-        let secondsLabel = null;
-        do {
-            minutesLabel = document.getElementById('minutes');
-            secondsLabel = document.getElementById('seconds');
-            if (loadingFinished()) {
-                clearInterval(counterId);
-                return;
-            }
-        } while (!(secondsLabel && minutesLabel));
-        ++totalSeconds;
-        secondsLabel.innerHTML = pad(totalSeconds % 60);
-        minutesLabel.innerHTML = pad(parseInt(totalSeconds / 60, 10));
-    };
-
-    const pad = (val) => {
-        const valString = `${val}`;
-        if (valString.length < 2) {
-            return `0${valString}`;
-        } else {
-            return valString;
-        }
-    };
-
-    const reloadBtn = viewButton(
-        model,
-        'Retry',
-        () => {
-            document.location.reload(true);
-        },
-        '',
-        undefined,
-        '.btn-primary.m3',
-    );
+export default function loading() {
+    const reloadBtn = h('button.btn.btn-primary.m3', {
+        onclick: () => document.location.reload(),
+    }, 'Retry');
     const loadingMessage = h('h3', 'Loading...');
-    const counter = h('h5.inline',
-        h('span.clear-both', { id: 'minutes' }, '00'),
-        h('span.clear-both', ':'),
-        h('span.clear-both', { id: 'seconds' }, '00'),
-        h('.tooltiptext2.tracker.p2.br3',
-            'If you are seeing this for way too long, then probably something is messed up'));
-
-    document.addEventListener('mousemove', (e) => {
-        saveCursorPosition(e.clientX, e.clientY);
-    });
-    setTimeout(() => initCounter(), 0);
 
     return h('.loginDiv.top-100', [
-        h('.my-tooltip-bg',
+        h('.panel',
             spinner(),
-            loadingMessage,
-            counter),
+            loadingMessage),
         reloadBtn,
     ]);
 }

app/public/views/waitingView.js

@@ -19,7 +19,7 @@ export default function waitingPanel() {
     const loadingMessage = h('h3', 'Loading...');
 
     return h('.loginDiv.top-100', [
-        h('.my-tooltip-bg',
+        h('.panel',
             spinner(),
             loadingMessage),
         reloadBtn,