Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORCT-117 - sequelize minimal model for runs per period view #131

Merged
merged 85 commits into from
Jul 26, 2023
Merged

ORCT-117 - sequelize minimal model for runs per period view #131

merged 85 commits into from
Jul 26, 2023

Conversation

xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Jul 20, 2023 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • PR labels are selected

Notable changes for users:

  • added endpoint /api/api-docs which return existing API description
  • added basic endpoint for listing runs, see. previous

Notable changes for developers:

  • basic usage of sequelize for all runs view (one pipeline)
  • reorganisation of DB - related classes
    • DatabaseManager - which holds references to all db related api
  • all endpoints public in dev mode (see env var ENV_MODE)
  • added option to expose DB container postgres port to host using rctmake with --db-expose HOST_PORT
  • tests

@xsalonx
Runs model refactor
5f43247
@xsalonx
Run model refacotr
07c70d2
@xsalonx
run model file rename
b6ecc1a
@xsalonx
added index to models
f9ad4ce
@xsalonx
added DatabaseManager
6153042
@xsalonx
added psql client to app contatiner
c31e42b
@xsalonx
Run model compatible with db
cdefd1b
@xsalonx
basics of repository added
5f45c52
@xsalonx
db utitlities added
8173c47
@xsalonx
refactor(renaming)
e6ff7ba
@xsalonx
Merge branch 'master' into improvement/ORCT-117/sequelize-minimal-mod…
0278cad 
…el-for-runs-per-period-view
@xsalonx
repository addition
c0e6010
@xsalonx
basics for routers and controllers
c138851
@xsalonx
init of Run controller
7022d19
@xsalonx
added routes creator
0b005ea
@xsalonx
routes parsing
36e26fd
@xsalonx
routes parsing added
e0f8907
@xsalonx
added binding of endpoints, public api in env mode
5f5e436
@xsalonx
master merged
14b0659
@xsalonx
cleanup
8856edb
@xsalonx
cleanup
87d83e7
@xsalonx
refator; cleanup
6ead4c6
@xsalonx
user privileges over db
d440e82
@xsalonx
refator; cleanup
3a0748a
@xsalonx
cleanup
7d1f211
@xsalonx
basic tests for server
2e2836d
@xsalonx xsalonx requested a review from Ehevi July 20, 2023 09:28
martinboulais
martinboulais requested changes Jul 25, 2023
View reviewed changes
app/application.js Outdated Show resolved Hide resolved
app/lib/database/models/Run.js Outdated Show resolved Hide resolved
app/lib/database/adapters/RunAdapter.js Outdated Show resolved Hide resolved
app/lib/database/repositories/index.js Outdated Show resolved Hide resolved
app/lib/database/repositories/index.js Outdated Show resolved Hide resolved
app/lib/usecases/runs/GetAllRuns.js Outdated Show resolved Hide resolved
martinboulais
martinboulais requested changes Jul 26, 2023
View reviewed changes
app/lib/usecases/runs/GetAllRuns.js Outdated Show resolved Hide resolved
app/application.js Outdated Show resolved Hide resolved
app/application.js Outdated Show resolved Hide resolved
@xsalonx xsalonx force-pushed the improvement/ORCT-117/sequelize-minimal-model-for-runs-per-period-view branch from 5e9c5b4 to 9f71507 Compare July 26, 2023 08:35
@xsalonx xsalonx merged commit 5b91dec into master Jul 26, 2023
3 of 5 checks passed
@xsalonx xsalonx deleted the improvement/ORCT-117/sequelize-minimal-model-for-runs-per-period-view branch July 26, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinboulais martinboulais martinboulais approved these changes

@Ehevi Ehevi Ehevi left review comments

Assignees

@xsalonx xsalonx

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xsalonx @martinboulais @Ehevi