Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ORCT-192] update legacy endpoint to handle migrated flags #233

Merged
merged 30 commits into from
Oct 11, 2023
Merged

[ORCT-192] update legacy endpoint to handle migrated flags #233

merged 30 commits into from
Oct 11, 2023

Conversation

xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Sep 28, 2023 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • display multiple verification
  • handle flag type mixed and NoData
  • add description whether flags is from synchronous qc or asynchronous

Notable changes for developers:

  • refactor flags_view
    • code refactor
    • verification returned as single array or json's with fields by and verification_time
  • flags model modified accordingly to mentioned above
  • fix bug in pagesCellSpecials for flags
  • allow to display migrated run based flags from temporary RCT on runsPerDataPassView ONLY. If there is no flag from table quality_control_flags, then quality from Bookkeeping is displayed.

Changes made to the database:

  • NA

@xsalonx xsalonx self-assigned this Sep 28, 2023
@xsalonx xsalonx requested a review from Ehevi September 28, 2023 13:01
@xsalonx xsalonx marked this pull request as ready for review September 28, 2023 13:01
@xsalonx xsalonx marked this pull request as draft October 5, 2023 08:46
@xsalonx xsalonx marked this pull request as ready for review October 5, 2023 11:40
martinboulais
martinboulais requested changes Oct 9, 2023
View reviewed changes
app/lib/database/views/flags_view.js Outdated Show resolved Hide resolved
app/lib/database/views/flags_view.js Outdated Show resolved Hide resolved
app/lib/database/views/flags_view.js Outdated Show resolved Hide resolved
app/lib/database/views/flags_view.js Outdated Show resolved Hide resolved
app/lib/database/views/flags_view.js Outdated Show resolved Hide resolved
app/lib/database/views/flags_view.js Outdated Show resolved Hide resolved
app/public/styles/rct/custom/components/run-quality.css Outdated Show resolved Hide resolved
app/public/views/userView/data/pagesCellsSpecials.js Outdated Show resolved Hide resolved
app/public/views/userView/data/pagesCellsSpecials.js Outdated Show resolved Hide resolved
app/public/views/flags/Flags.js Outdated Show resolved Hide resolved
@xsalonx xsalonx merged commit 006f8f8 into master Oct 11, 2023
3 of 4 checks passed
@xsalonx xsalonx deleted the improvement/ORCT-192/update-legacy-endpoint-to-handle-migrated-flags branch October 11, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinboulais martinboulais martinboulais approved these changes

@Ehevi Ehevi Awaiting requested review from Ehevi

Assignees

@xsalonx xsalonx

Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xsalonx @martinboulais