[OGUI-1608] Refactor to update FrameworkInfo to AboutView #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age, rename and reorganize files in 'pages' folder
…ure/OGUI-1608/refactor-frameworkinfo
graduta
requested changes
Feb 7, 2025
QualityControl/public/Model.js
Outdated
| @@ -261,7 +261,7 @@ export default class Model extends Observable { | |||
| case 'about': | |||
| this.page = 'about'; | |||
| setBrowserTabTitle('QCG-About'); | |||
| this.frameworkInfo.getFrameworkInfo(); | |||
| this.aboutViewModel.getAboutViewModel(); | |||
There was a problem hiding this comment.
Hi @mariscalromeroalejandro. What is the reason for renaming this method to suggest that a model is retrieved?
| @@ -30,10 +30,10 @@ export default class FrameworkInfo extends Observable { | |||
| } | |||
|
|
|||
| /** | |||
| * Load FrameworkInfo into `item` | |||
| * Load About Model into `item` | |||
There was a problem hiding this comment.
The model is the class itself.
This method does not Load About Model into item``.
In item, data about the server of the GUI and associated services is stored in a remotedata. A remote data is used so that a nice UX is provided to the User, to know when items are loading, failed, or successfully loaded.
graduta
approved these changes
Feb 11, 2025
mariscalromeroalejandro
deleted the
feature/OGUI-1608/refactor-frameworkinfo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request: