Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1158: Allow mail addresses with different full names #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

skruppy
Copy link
Contributor

@skruppy skruppy commented Mar 15, 2014

As stated in http://www.sogo.nu/bugs/view.php?id=1158, the the MailFieldNames fields (like mail) can only contain a plain E-Mail address, without a full name like "Dude" [email protected]. If the value contains never the less a full value, something strange happened:

  • Since SOGo 2.2.1: The result would have been "Bro" <"Dude" [email protected]>
  • Before SOGo 2.2.1: The result would have been "Bro" [email protected]
    therefore the only sane values have been without a full name and "<>".

Now it is possible to have

  • E-Mail addresses without a full name
  • E-Mail addresses with a different full name

to accomplish this, without breaking backward compatibility for former sane configurations, the new behavior only kicks in if the value contains a "<". Depending on it's position, one of the two new E-Mails address types is selected. The mapping is as following:

Input Result Users fullName
[email protected] "Bro" [email protected] "Bro"
[email protected] [email protected] ""
[email protected] [email protected] "Bro" or ""
"Dude" [email protected] "Dude" [email protected] "Bro" or ""

@extrafu
Copy link
Contributor

extrafu commented Apr 3, 2014

Nice work, this will likely be integrated in SOGo v2.5.

@dasJ
Copy link
Contributor

dasJ commented Jul 22, 2019

really?

jkanefendt pushed a commit to jkanefendt/sogo that referenced this pull request Jul 2, 2020
Stage 6 of clang compiler warning patches. Fix hidden method in NGIma…
@Neustradamus
Copy link
Contributor

@Alinto: What is the status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants