Fix 'Test is missing assertions' warnings

AllYourBot · Nov 10, 2024 · 354582e · 354582e
1 parent 5e967ec
commit 354582e
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/test/controllers/active_storage/postgresql_controller_test.rb b/test/controllers/active_storage/postgresql_controller_test.rb
@@ -52,6 +52,7 @@ class ActiveStorage::PostgresqlControllerTest < ActionDispatch::IntegrationTest
     blob.delete
 
     get blob.send(url_method)
+    assert_response :not_found
   end
 
   test "showing blob with invalid key" do

diff --git a/test/models/api_service_test.rb b/test/models/api_service_test.rb
@@ -57,7 +57,7 @@ class APIServiceTest < ActiveSupport::TestCase
   end
 
   test "can create record" do
-    APIService.create!(create_params)
+    assert APIService.create!(create_params)
   end
 
   test "soft delete also soft deletes language_models" do

diff --git a/test/models/message/version_test.rb b/test/models/message/version_test.rb
@@ -66,7 +66,7 @@ class Message::VersionTest < ActiveSupport::TestCase
 
   test "creating a message with branched true AND branched_from_version specified SUCCEEDS" do
     Current.user = users(:keith)
-    conversations(:versioned).messages.create!(assistant: assistants(:samantha), content_text: "What is your name?", index: 2, version: 3, branched: true, branched_from_version: 2)
+    assert conversations(:versioned).messages.create!(assistant: assistants(:samantha), content_text: "What is your name?", index: 2, version: 3, branched: true, branched_from_version: 2)
   end
 
   test "creating a new messages for a SPECIFIC INDEX and SPECIFIC VERSION fails if the VERSION is SKIPPING a number" do

diff --git a/test/services/ai_backend/anthropic_test.rb b/test/services/ai_backend/anthropic_test.rb
@@ -48,11 +48,11 @@ class AIBackend::AnthropicTest < ActiveSupport::TestCase
     end
   end
 
-  test "preceding_conversation_messages only considers messages on the intended conversation version and includes the correct names" do
-    # TODO
-  end
+  # TODO
+  # test "preceding_conversation_messages only considers messages on the intended conversation version and includes the correct names" do
+  # end
 
-  test "preceding_conversation_messages includes the appropriate tool details" do
-    # TODO
-  end
+  # TODO
+  # test "preceding_conversation_messages includes the appropriate tool details" do
+  # end
 end