upgrade rails to 7.2 #523
upgrade rails to 7.2 #523
Conversation
|
working towards the defaults for 7.2 and then I'll remove this file: config/initializers/new_framework_defaults_7_2.rb |
db/schema.rb
Outdated
| @@ -10,7 +10,7 @@ | |||
| # | |||
| # It's strongly recommended that you check this file into your version control system. | |||
|
|
|||
| ActiveRecord::Schema[7.1].define(version: 2024_09_15_034529) do | |||
| ActiveRecord::Schema[7.1].define(version: 2024_10_21_060860) do | |||
| # These are extensions that must be enabled in order to support this database | |||
There was a problem hiding this comment.
Notably there are migrations but the schema file didn't update. Were those migrations no-ops or do you need to run db:migrate still to get the schema updated?
The app's use of ActiveStorage is pretty hacky, since it's all uploaded image files are being stored in ActiveRecord. With these new migrations and this upgrade to 7.2, be sure to test out that functionality in your dev environment to make sure the various AIs can can still answer questions about images. (If can't remember if I got it working on all three or not, if it doesn't work on Llama it may be that I only implemented it for GPT and Claude)
There was a problem hiding this comment.
the migrations are already in place, I think because we started on 7.1.3 but I wasn't certain if they were doing anything different with the 7.1.4 update so I just left them. I guess since the schema.rb didn't change then they can be removed. I'll check on the ActiveStorage functionality to make sure it's working
|
getting this a lot with the 7.2 update: |
this might be a fix though: rails/rails#53147 (comment) |
| @@ -7,7 +7,7 @@ class APIService < ApplicationRecord | |||
|
|
|||
| has_many :language_models, -> { not_deleted } | |||
|
|
|||
| enum driver: %w[ openai anthropic ].index_by(&:to_sym) | |||
| enum :driver, %w[ openai anthropic ].index_by(&:to_sym) | |||
There was a problem hiding this comment.
the old syntax is deprecated so moving to positional arguments with the enums
|
ok seems to be working, but we should wait on a release of 7.2 with a fix so we don't have to point to the 7-2-stable branch - something later than 7.2.1.2 will hopefully have the fix: https://github.com/rails/rails/releases |
No description provided.