Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic "best" Language Model #538

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Conversation

drnic
Copy link
Contributor

@drnic drnic commented Nov 6, 2024

Instead of constants in code, adding a LanguageModel#best? field. Only one LanguageModel per APIService can be the best.

Best models are at top of table, then ordered by position:

Screenshot 2024-11-07 at 8 24 09 am

Toggle a language model to be the new "best" model for that API Service:

Screenshot 2024-11-07 at 8 16 45 am

The language model used for an assistant is now clear, rather than "Anthropic Best", etc:

Screenshot 2024-11-07 at 8 02 20 am

@drnic drnic mentioned this pull request Nov 7, 2024
3 tasks
@drnic
Copy link
Contributor Author

drnic commented Nov 7, 2024

PR rebased against main and passing CI

@drnic
Copy link
Contributor Author

drnic commented Nov 10, 2024

@krschacht bump; this PR might have gotten lost amongst my other PRs last week

@krschacht krschacht merged commit 692ff03 into AllYourBot:main Nov 10, 2024
6 checks passed
@krschacht
Copy link
Contributor

@drnic Thanks for the bump and sorry for the delay. I just gave it a close review and it looks great. I tested it out locally and the only issue I found was that I couldn't run db:migrate from scratch. I'm not certain that it's important to support this, but sometimes I've seen that catch a dev off guard so I fixed that. But it doesn't look like I can push to your branch so I just hotfixed this into main (5e967ec)

The one other thing I noticed is that it possible to go into settings and uncheck the "best" one leaving no best. I worried this might cause a problem, but my existing assistants still work and new users can still register so I think we're fine. But I'm calling this out in case it raises any red flags for you. Keep it in mind in your other PR because if that becomes a problem then we may need to add some guards for it.

But overall great work!

@drnic drnic deleted the best-model-migration branch November 10, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants