Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: anvil, stonecutter, grindstone containers type #596

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: anvil, stonecutter, grindstone containers type #596

wants to merge 3 commits into from

Conversation

IWareQ
Copy link
Member

@IWareQ IWareQ commented Mar 6, 2025 •
edited
Loading

  • Anvil
  • Grindstone
  • Stonecutter

Close #174

@IWareQ IWareQ linked an issue Mar 6, 2025 that may be closed by this pull request
feat: anvil, stonecutter, grindstone and other #174
Open
@IWareQ IWareQ self-assigned this Mar 6, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 32.84672% with 92 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ontainer/processor/CraftRecipeActionProcessor.java 0.00% 39 Missing ⚠️
...org/allaymc/api/container/impl/AnvilContainer.java 0.00% 11 Missing ⚠️
...llaymc/api/container/impl/GrindstoneContainer.java 0.00% 11 Missing ⚠️
...ponent/BlockStonecutterBlockBaseComponentImpl.java 18.18% 9 Missing ⚠️
...laymc/api/container/impl/StonecutterContainer.java 0.00% 8 Missing ⚠️
...t/furnace/BlockEntityFurnaceBaseComponentImpl.java 0.00% 4 Missing ⚠️
...i/container/impl/PlayerCreatedOutputContainer.java 0.00% 2 Missing ⚠️
.../allaymc/api/item/recipe/impl/PotionMixRecipe.java 0.00% 2 Missing ⚠️
.../allaymc/api/item/recipe/impl/ShapelessRecipe.java 60.00% 1 Missing and 1 partial ⚠️
...aymc/api/container/impl/CraftingGridContainer.java 0.00% 1 Missing ⚠️
... and 3 more
Files with missing lines Coverage Δ Complexity Δ
...a/org/allaymc/api/container/FullContainerType.java 89.83% <100.00%> (+1.51%) 5.00 <0.00> (ø)
.../allaymc/api/container/impl/CraftingContainer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...g/allaymc/api/item/recipe/impl/CraftingRecipe.java 90.00% <ø> (ø) 2.00 <0.00> (ø)
...ymc/api/item/recipe/input/CraftingRecipeInput.java 71.42% <ø> (ø) 10.00 <0.00> (?)
...aymc/api/item/recipe/input/FurnaceRecipeInput.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...llaymc/server/block/type/BlockTypeInitializer.java 96.30% <100.00%> (+0.02%) 87.00 <1.00> (+1.00)
...aymc/api/container/impl/CraftingGridContainer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ymc/api/container/impl/CraftingTableContainer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rg/allaymc/api/item/recipe/impl/FurnaceRecipe.java 50.00% <66.66%> (ø) 6.00 <2.00> (ø)
...org/allaymc/api/item/recipe/impl/ShapedRecipe.java 78.31% <50.00%> (ø) 27.00 <6.00> (ø)
... and 9 more
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

smartcmd
smartcmd requested changes Mar 6, 2025
View reviewed changes
Copy link
Member

@smartcmd smartcmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG.MD (

@IWareQ
feat: stonecutter
93d48ee 
refactor: CraftRecipeActionProcessor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartcmd smartcmd smartcmd requested changes

Assignees

@IWareQ IWareQ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: anvil, stonecutter, grindstone and other
2 participants
@IWareQ @smartcmd