Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make saving requirements optional #408

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Make saving requirements optional #408

merged 1 commit into from
Aug 8, 2024

Conversation

saeliddp
Copy link
Contributor

@saeliddp saeliddp commented Jul 31, 2024

What does this PR do?

Makes saving requirements to hparams.yaml using pip freeze optional. This is in order to allow plugin devs to use PDM. Tested with an editable cyto-dl install + plugin and pdm, and this change seems to work.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@saeliddp saeliddp merged commit cee8402 into main Aug 8, 2024
4 of 6 checks passed
@saeliddp saeliddp deleted the make-req-optional branch August 8, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants