Changed logistic model code to match description #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In the final exercise, in the exponent of the exponential, the parameter `a` is multiplying the other term - However, in the accompanying code, the parameter `a` is dividing it - The accompanying Wikipedia link about Item Response Theory also uses the convention of multiplying in the factor `a` - Easy fix: in the code switch `a` from `a = 100` to `a = 1 / 100`, and switch it it multiplication in the assignment to `x` - Closes AllenDowney#49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parameter
ais multiplying the other termais dividing itthe convention of multiplying in the factor
aafroma = 100toa = 1 / 100, andswitch it to multiplication in the assignment to
x