Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

albs-sign-node: install glibc-langpack-en #57

Merged
merged 2 commits into from
Apr 23, 2024
Merged

albs-sign-node: install glibc-langpack-en #57

merged 2 commits into from
Apr 23, 2024

Conversation

metalefty
Copy link
Member

@metalefty metalefty commented Feb 19, 2024

@metalefty metalefty self-assigned this Feb 19, 2024
Copy link

github-actions bot commented Feb 19, 2024

Total coverage

Coverage report for changed files •
FileStmtsMissCoverMissing
TOTAL107181923% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
1 0 💤 0 ❌ 0 🔥 1.056s ⏱️

@metalefty
Copy link
Member Author

@javihernandez
Copy link
Member

@javihernandez Commit Message Check is not checking the latest commit, any ideas? I force-pushed 0ec8965 and it is the latest commit.

There's a TAB between Resolves: and link - it should be a blank space

@metalefty
Copy link
Member Author

No no, I didn't mean that.

@metalefty
Copy link
Member Author

Ah, sorry. The CI task name confused me. I had assumed it complains about commit message because the task is named "Commit Message Check". It is not a very good name :(

image

@metalefty
Copy link
Member Author

metalefty commented Feb 20, 2024

What I tried to fix in the pull request is to ensure glibc-langpack-en installed in the albs-sign-node container that uses en_US.UTF-8 locale. glibc-langpack-en must be installed to use en_* locales.

$ rpm -ql glibc-langpack-en
/usr/lib/locale
/usr/lib/locale/en_AG
/usr/lib/locale/en_AG/LC_ADDRESS
/usr/lib/locale/en_AG/LC_COLLATE
/usr/lib/locale/en_AG/LC_CTYPE
/usr/lib/locale/en_AG/LC_IDENTIFICATION
...
/usr/lib/locale/en_ZW/LC_PAPER
/usr/lib/locale/en_ZW/LC_TELEPHONE
/usr/lib/locale/en_ZW/LC_TIME
/usr/share/locale/en_GB/LC_MESSAGES/libc.mo

The easiest code to reproduce kind of error reported in the original issue AlmaLinux/build-system#196 is just a 2-line python code.

#!/usr/bin/python

import locale
locale.setlocale(locale.LC_ALL, "en_US.UTF-8")

glibc-langpack-en is not installed

$ rpm -qa | grep glibc-langpack-en
$

$ python localecheck.py
Traceback (most recent call last):
  File "/tmp/localecheck.py", line 5, in <module>
    locale.setlocale(locale.LC_ALL, "en_US.UTF-8")
  File "/usr/lib64/python3.9/locale.py", line 610, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting

glibc-langpack-en is installed

$ sudo dnf install -y glibc-langpack-en
$

$ python localecheck.py
$

Success without error.

@Korulag Korulag merged commit 67877be into master Apr 23, 2024
2 checks passed
@Korulag Korulag deleted the locale branch April 23, 2024 08:43
Copy link

1 passed

Code Coverage Summary

Package Line Rate
sign_node 27%
sign_node.uploaders 28%
sign_node.utils 18%
Summary 24% (253 / 1074)

View full reports on the Job Summary page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants