Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update tsconfig option to resolve publishing types issue #258

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

feat: update tsconfig option to resolve publishing types issue #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c762028
fix(notifier): update `tsconfig` options
mohammadhonarvar Oct 31, 2024
76799b9
fix(api): update `tsconfig` options
mohammadhonarvar Oct 31, 2024
74b215b
chore(.vscode): update settings
mohammadhonarvar Oct 31, 2024
fc45f52
fix(notifier): add the correct options of `fetch` to `fetchJson`
mohammadhonarvar Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
"explorer.fileNesting.enabled": true,
"explorer.fileNesting.expand": false,
"explorer.fileNesting.patterns": {
"*.js": "${capture}.js.map, ${capture}.min.js, ${capture}.d.ts, ${capture}.d.ts.map",
"*.js": "${capture}.js.map, ${capture}.min.js, ${capture}.d.ts, ${capture}.d.ts.map, ${capture}.js.LEGAL.txt",
"*.mjs": "${capture}.mjs.map, ${capture}.min.mjs, ${capture}.d.ts, ${capture}.d.ts.map, ${capture}.mjs.LEGAL.txt, ${capture}.cjs",
"*.cjs": "${capture}.cjs.map, ${capture}.min.cjs, ${capture}.d.ts, ${capture}.d.ts.map, ${capture}.cjs.LEGAL.txt",
"*.ts": "${capture}.js, ${capture}.js.map, ${capture}.d.ts, ${capture}.d.ts.map",
"tsconfig.json": "tsconfig.*.json, *.tsbuildinfo"
},
Expand Down
5 changes: 3 additions & 2 deletions packages/api/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
"extends": "@alwatr/tsconfig-base/tsconfig.json",
"compilerOptions": {
"rootDir": "src",
// "outDir": "dist",
"noEmit": true,
"outDir": "dist",
"emitDeclarationOnly": true,
"composite": true,
"types": ["node", "@alwatr/nano-build", "@alwatr/type-helper"]
},
"include": ["src/**/*.ts"],
Expand Down
5 changes: 3 additions & 2 deletions packages/notifier/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
},
"license": "AGPL-3.0-only",
"files": [
"**/*.{js,mjs,cjs,map,d.ts,html,md}",
"**/*.{js,mjs,cjs,map,d.ts,html,md,LEGAL.txt}",
"LICENSE",
"!demo/**/*"
],
"publishConfig": {
Expand All @@ -48,7 +49,7 @@
"c": "yarn run clean",
"cb": "yarn run clean && yarn run build",
"d": "yarn run build:es && yarn node --enable-source-maps --trace-warnings",
"build": "yarn run build:ts & yarn run build:es",
"build": "yarn run build:ts && yarn run build:es",
"build:es": "nano-build --preset=module",
"build:ts": "tsc --build",
"test": "NODE_OPTIONS=\"$NODE_OPTIONS --enable-source-maps --experimental-vm-modules\" jest",
Expand Down
2 changes: 1 addition & 1 deletion packages/notifier/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export class AlwatrNotifier {
}

return fetchJson({
...option?.fetchOption,
...option_.fetchOption,
url: resolveUrl(option_.apiUrl, '/api/v2/notify'),
bearerToken: option_.accessToken,
bodyJson: {
Expand Down
5 changes: 3 additions & 2 deletions packages/notifier/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
"extends": "@alwatr/tsconfig-base/tsconfig.json",
"compilerOptions": {
"rootDir": "src",
// "outDir": "dist",
"noEmit": true,
"outDir": "dist",
"emitDeclarationOnly": true,
"composite": true,
"types": ["node", "@alwatr/nano-build", "@alwatr/type-helper"]
},
"include": ["src/**/*.ts"],
Expand Down