Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding className as a common prop for all widgets #115

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

divdavem
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #115 (fae422c) into main (bac770c) will decrease coverage by 10.54%.
The diff coverage is 80.95%.

@@             Coverage Diff             @@
##             main     #115       +/-   ##
===========================================
- Coverage   98.95%   88.42%   -10.54%     
===========================================
  Files          27       69       +42     
  Lines        4220     5217      +997     
  Branches      288      461      +173     
===========================================
+ Hits         4176     4613      +437     
- Misses         40      559      +519     
- Partials        4       45       +41     
Flag Coverage Δ
e2e-2 18.16% <0.00%> (?)
e2e-4 74.76% <ø> (?)
e2e-7 59.28% <33.33%> (?)
e2e-8 31.27% <0.00%> (?)
unit 98.95% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...gular/lib/src/lib/accordion/accordion.component.ts 4.93% <ø> (ø)
angular/lib/src/lib/alert/alert.component.ts 6.81% <0.00%> (ø)
angular/lib/src/lib/modal/modal.component.ts 5.63% <0.00%> (ø)
...lar/lib/src/lib/pagination/pagination.component.ts 3.40% <ø> (ø)
angular/lib/src/lib/rating/rating.component.ts 2.85% <ø> (ø)
angular/lib/src/lib/select/select.component.ts 100.00% <ø> (ø)
react/lib/Accordion.tsx 23.80% <ø> (ø)
react/lib/Alert.tsx 100.00% <ø> (ø)
react/lib/modal/Modal.tsx 88.23% <ø> (ø)
svelte/lib/accordion/Accordion.svelte 0.00% <0.00%> (ø)
... and 8 more

... and 30 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@divdavem divdavem marked this pull request as ready for review August 29, 2023 08:14
@divdavem divdavem changed the title Adding className as a common prop for all components Adding className as a common prop for all widgets Aug 29, 2023
@divdavem divdavem requested a review from fbasso August 29, 2023 08:15
@@ -0,0 +1,6 @@
export interface AllWidgetsCommonPropsAndState {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that just WidgetsCommonPropsAndState as a name is enough ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion. I have renamed the interface.

Copy link
Contributor

@fbasso fbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me, thanks @divdavem !

@divdavem
Copy link
Member Author

divdavem commented Sep 1, 2023

@fbasso Thank you for your review!

@divdavem divdavem merged commit 05102b5 into AmadeusITGroup:main Sep 12, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants