-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding className as a common prop for all widgets #115
Conversation
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
===========================================
- Coverage 98.95% 88.42% -10.54%
===========================================
Files 27 69 +42
Lines 4220 5217 +997
Branches 288 461 +173
===========================================
+ Hits 4176 4613 +437
- Misses 40 559 +519
- Partials 4 45 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 30 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
core/lib/commonProps.ts
Outdated
@@ -0,0 +1,6 @@ | |||
export interface AllWidgetsCommonPropsAndState { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that just WidgetsCommonPropsAndState
as a name is enough ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your suggestion. I have renamed the interface.
022e36e
to
fae422c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me, thanks @divdavem !
@fbasso Thank you for your review! |
No description provided.