demo: accordion sample simplification #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbasso
requested review from
divdavem,
ExFlo,
ValentinNelu and
quentinderoubaix
Codecov Report
@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 88.31% 91.77% +3.46%
==========================================
Files 53 26 -27
Lines 1386 936 -450
Branches 218 165 -53
==========================================
- Hits 1224 859 -365
+ Misses 125 53 -72
+ Partials 37 24 -13
Flags with carried forward coverage won't be shown. Click here to find out more. see 32 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Actually with this PR we are already cleaning a lot the code, what do you think? @quentinderoubaix |
|
No longer applicable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose is to simplify the accordion examples, to render the displayed code more readable (less text in the bodies).