Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add link to Twitter AgnosUI account #24

Merged
merged 1 commit into from
Jul 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

---

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
Expand All @@ -24,15 +24,17 @@ A clear and concise description of what you expected to happen.
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Smartphone (please complete the following information):**
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

**Additional context**
Add any other context about the problem here.
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ about: Suggest an idea for this project
title: ''
labels: ''
assignees: ''

---

**Is your feature request related to a problem? Please describe.**
Expand Down
8 changes: 6 additions & 2 deletions demo/src/routes/+layout.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import {selectedFramework$} from '../lib/stores';
import Svg from '$lib/layout/Svg.svelte';
import github from 'bootstrap-icons/icons/github.svg?raw';
import twitter from 'bootstrap-icons/icons/twitter.svg?raw';
</script>

<svelte:head>
Expand All @@ -19,9 +20,12 @@
<a class="navbar-brand" href={$pathToRoot$}> AgnosUI </a>
<div class="d-flex align-items-center">
<a class="nav-link text-white" href="https://github.com/AmadeusITGroup/AgnosUI" aria-label="link to GitHub repository" target="_blank">
<Svg className="icon-20 align-middle" svg={github} />
<Svg className="icon-24 align-middle" svg={github} />
</a>
<span class="ms-2 navbar-text">v{import.meta.env.AGNOSUI_VERSION}</span>
<a class="nav-link text-white ms-3" href="https://twitter.com/AgnosUI" aria-label="link to twitter account" target="_blank">
<Svg className="icon-24 align-middle" svg={twitter} />
</a>
<span class="ms-3 text-white">v{import.meta.env.AGNOSUI_VERSION}</span>
</div>
</div>
</nav>
Expand Down
4 changes: 4 additions & 0 deletions demo/src/routes/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -174,4 +174,8 @@ header {
width: 20px;
height: 20px;
}
&.icon-24 {
width: 24px;
height: 24px;
}
}
8 changes: 1 addition & 7 deletions e2e/demo.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,7 @@ const allRoutes = globSync(`${pathToFrameworkDir}/**/+page.svelte`).map((route)
);

async function analyze(page: Page): Promise<AxeResults> {
return (
new AxeBuilder({page})
.withTags(['wcag2a', 'wcag2aa', 'wcag21a', 'wcag21aa'])
// TODO remove the color-contrast exclusion once we have decided on the theming of the demos
.disableRules(['color-contrast'])
.analyze()
);
return new AxeBuilder({page}).withTags(['wcag2a', 'wcag2aa', 'wcag21a', 'wcag21aa']).disableRules(['color-contrast']).analyze();
}

test.describe.parallel('Demo Website', () => {
Expand Down
Loading