Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] refactor: removing bindableDerived #322

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

divdavem
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (aa91c1e) 91.83% compared to head (d5325dd) 84.74%.

Files Patch % Lines
core/src/components/pagination/pagination.ts 66.66% 2 Missing ⚠️
core/src/components/select/select.ts 77.77% 2 Missing ⚠️
core/src/components/slider/slider.ts 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
- Coverage   91.83%   84.74%   -7.10%     
==========================================
  Files          81       79       -2     
  Lines        2083     1986      -97     
  Branches      368      345      -23     
==========================================
- Hits         1913     1683     -230     
- Misses        100      188      +88     
- Partials       70      115      +45     
Flag Coverage Δ
e2e-1 61.62% <25.53%> (+0.06%) ⬆️
e2e-2 58.12% <78.72%> (+0.23%) ⬆️
e2e-4 68.99% <9.67%> (+0.46%) ⬆️
e2e-5 79.32% <87.23%> (+0.11%) ⬆️
e2e-7 54.35% <9.67%> (-0.63%) ⬇️
e2e-8 77.50% <87.23%> (+0.39%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant