Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add callback events cases #473

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

fbasso
Copy link
Contributor

@fbasso fbasso commented Feb 9, 2024

PR to discuss about controlled/uncontrolled widget and when the events must be triggers.

I just added two test for now. It simulates a select, where the user inputs are changed in uppercase, and monitor the onTextFilterChange and the onOpenChange callbacks.

Run the test with npm run tdd:ui core select and have a look at the expect statements.

@fbasso fbasso marked this pull request as draft February 9, 2024 10:19
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.53%. Comparing base (c86d2c0) to head (9a795b5).

❗ There is a different number of reports uploaded between BASE (c86d2c0) and HEAD (9a795b5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c86d2c0) HEAD (9a795b5)
unit 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   93.28%   83.53%   -9.75%     
==========================================
  Files          65       64       -1     
  Lines        2069     2065       -4     
  Branches      369      369              
==========================================
- Hits         1930     1725     -205     
- Misses         75      209     +134     
- Partials       64      131      +67     
Flag Coverage Δ
e2e 83.53% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant