lazy loaded routes for samples #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 72 72
Lines 2081 2081
Branches 366 366
=======================================
Hits 1916 1916
Misses 101 101
Partials 64 64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
quentinderoubaix
force-pushed
the
46-sample-urls-should-only-import-required-widgets
branch
from
64e3158
to
abe1620
Compare
quentinderoubaix
changed the title
quentinderoubaix
force-pushed
the
46-sample-urls-should-only-import-required-widgets
branch
from
abe1620
to
8f55859
Compare
quentinderoubaix
changed the title
quentinderoubaix
force-pushed
the
46-sample-urls-should-only-import-required-widgets
branch
5 times, most recently
from
8c4a6b7
to
6d4993b
Compare
quentinderoubaix
force-pushed
the
46-sample-urls-should-only-import-required-widgets
branch
from
6d4993b
to
ebb3a7f
Compare
divdavem
reviewed
Dec 5, 2023
| let resizeObserver: ResizeObserver | undefined; | ||
| let heightSubscription: (UnsubscribeFunction & UnsubscribeObject) | undefined; | ||
|
|
||
| const setupObserver = (iframe: HTMLIFrameElement) => { |
There was a problem hiding this comment.
As discussed, this should be extracted (as part of another PR) in a reactive utility in the core (similar to the intersection utility) that could also be used in the slider.
There was a problem hiding this comment.
Tracked in #291
divdavem
approved these changes
Dec 5, 2023
quentinderoubaix
deleted the
46-sample-urls-should-only-import-required-widgets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.