feat: Create tree component #999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkoOleksiyenko
force-pushed
the
tree-component
branch
3 times, most recently
from
ab1a56b
to
8ff4407
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
==========================================
- Coverage 92.08% 84.74% -7.34%
==========================================
Files 94 49 -45
Lines 2528 2013 -515
Branches 420 369 -51
==========================================
- Hits 2328 1706 -622
- Misses 130 221 +91
- Partials 70 86 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MarkoOleksiyenko
force-pushed
the
tree-component
branch
4 times, most recently
from
451b793
to
a1dda6b
Compare
MarkoOleksiyenko
requested review from
ExFlo,
quentinderoubaix,
divdavem,
fbasso and
ValentinNelu
MarkoOleksiyenko
force-pushed
the
tree-component
branch
from
a1dda6b
to
0fa9f4e
Compare
|
Hi the screenreader is not fully working when expanding / collapsing the node. |
ExFlo
requested changes
Nov 5, 2024
MarkoOleksiyenko
force-pushed
the
tree-component
branch
from
0fa9f4e
to
71add32
Compare
MarkoOleksiyenko
force-pushed
the
tree-component
branch
2 times, most recently
from
208c027
to
16b8cac
Compare
ExFlo
reviewed
Nov 13, 2024
| ); | ||
| } | ||
| /** | ||
| * Optional accessiblity label for the tree if there is no explicit label |
core/src/components/tree/tree.ts
Outdated
| */ | ||
| export interface TreeItem { | ||
| /** | ||
| * Accessiblity label for the node |
core/src/components/tree/tree.ts
Outdated
|
|
||
| interface TreeCommonPropsAndState extends WidgetsCommonPropsAndState { | ||
| /** | ||
| * Optional accessiblity label for the tree if there is no explicit label |
| */ | ||
| @Input('auClassName') className: string | undefined; | ||
| /** | ||
| * Retrieves expand items of the TreeItem |
There was a problem hiding this comment.
how querySelectorAll button could return Span or Input ?
There was a problem hiding this comment.
forgot to change to the HTMLButton :)
| $au-tree-expand-button-border-radius: 0.375rem !default; | ||
| $au-tree-expand-button-background-color: transparent !default; | ||
| $au-tree-expand-button-background-color-hover: #c5d5f9 !default; | ||
| $au-tree-expand-icon-color-default: blue !default; // TODO change to a proper color |
There was a problem hiding this comment.
use proper css var of BS with default value like for the slider
core-bootstrap/src/scss/tree.scss
Outdated
|
|
||
| .au-tree-expand-button-placeholder { | ||
| display: flex; | ||
| width: 2.75rem; |
core-bootstrap/src/scss/tree.scss
Outdated
|
|
||
| .au-tree-expand-button { | ||
| position: relative; | ||
| width: 2.25rem; |
core/src/components/tree/tree.ts
Outdated
| attributes: { | ||
| 'aria-label': computed(() => { | ||
| const {item} = treeItemContext$(); | ||
| return `Toggle ${item.label}`; |
| }; | ||
|
|
||
| /** | ||
| * A functional component that renders a tree item elemen. |
| const widget = callWidgetFactory({ | ||
| factory: createTree, | ||
| widgetName: 'tree', | ||
| props: {...props}, |
There was a problem hiding this comment.
don't you need a getter here ?
There was a problem hiding this comment.
yeah, the new update
MarkoOleksiyenko
force-pushed
the
tree-component
branch
from
16b8cac
to
c890575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following:
Tests and linting
npm run testnpm run lintnpm run e2eThank you for contributing to AgnosUI!