Skip to content

Commit

Permalink
[chore] remove tests checking nil consumer as we're handling nil chec…
Browse files Browse the repository at this point in the history
…ks in builder (open-telemetry#31172)

See open-telemetry/opentelemetry-collector#9526
for context - we are removing the possibility that the next consumer
passed in is nil in the pipelines builders.
  • Loading branch information
atoulme authored Feb 9, 2024
1 parent 2047ee9 commit 384a94d
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions processor/attributesprocessor/factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,6 @@ func TestFactoryCreateTracesProcessor(t *testing.T) {
assert.NotNil(t, tp)
assert.NoError(t, err)

tp, err = factory.CreateTracesProcessor(context.Background(), processortest.NewNopCreateSettings(), cfg, nil)
assert.Nil(t, tp)
assert.Error(t, err)

oCfg.Actions = []attraction.ActionKeyValue{
{Action: attraction.DELETE},
}
Expand All @@ -92,10 +88,6 @@ func TestFactory_CreateMetricsProcessor(t *testing.T) {
require.NotNil(t, mp)
require.NoError(t, err)

mp, err = factory.CreateMetricsProcessor(context.Background(), processortest.NewNopCreateSettings(), cfg, nil)
require.Nil(t, mp)
require.Error(t, err)

cfg.(*Config).Actions = []attraction.ActionKeyValue{
{Key: "fake_key", Action: attraction.UPSERT},
}
Expand Down Expand Up @@ -132,11 +124,6 @@ func TestFactoryCreateLogsProcessor(t *testing.T) {
assert.NotNil(t, tp)
assert.NoError(t, err)

tp, err = factory.CreateLogsProcessor(
context.Background(), processortest.NewNopCreateSettings(), cfg, nil)
assert.Nil(t, tp)
assert.Error(t, err)

oCfg.Actions = []attraction.ActionKeyValue{
{Action: attraction.DELETE},
}
Expand Down

0 comments on commit 384a94d

Please sign in to comment.