Feature/azuremonitorreceiver/use batch api rebased #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the Batch API. Currently a Proof-of-Concept that does not allow Resources to exist in different regions and does not filter based on dimensions similar to how it's being handled in the previous implementation (by Resource). Fix errors that were not ocurring during testing azure monitor receiver - getBatch few enhancement Implemented automatic discovery of subscriptions Fix concurrent multi goroutines Add timegrain as attrivutes retrieve twice timerange only for PT1M and always query (do not wait timegrain) FIX timegrain PT1M get multiple time Fix limits of 50 resources per getBatch API calls Retreive 4 timeranges for metrics and keep only latest timestamp containing metrics values Remove misleading warning log fix for loop iterations for resourceIds fix for loop iterations for resourceIds fix - do not return when getBatch returns an error Azure Monitor Receiver: Update the logic for when to pull batches by calculating the nearest minute and then add a check to ensure the last update was not within the time grain. In addition add more logging around erorrs received from the Batch API by casting to the Azure Response Error type and logging the full error. Revert "Azure Monitor Receiver: Update the logic for when to pull batches by calculating the nearest minute and then add a check to ensure the last update was not within the time grain. In addition add more logging around erorrs received from the Batch API by casting to the Azure Response Error type and logging the full error." This reverts commit e908a55.
celian-garcia
suggested changes
Oct 18, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes
Testing
Documentation