Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile and move tests using pytrec_eval into a specific test folder #43

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

diegoceccarelli
Copy link
Collaborator

Add a Makefile with targets to simplify development. I would add more checks in future PRs.

Note that pytrec_eval is not listed a dependency at the moment (and it creates problem to me when I try to install behind a vpn because the setup.pytries to access a website). I'm not surepytrec_eval` is MIT compliant in terms of license (see cvangysel/pytrec_eval#44).

Given that is used only for tests I moved the tests using it into a specific folder and ignore it in the test target. Happy to add a target that install pytrec_eval and run the missing tests.

@diegoceccarelli
Copy link
Collaborator Author

Add a Makefile with targets to simplify development. I would add more checks in future PRs.

Note that pytrec_eval is not listed as a dependency at the moment (and it creates a problem to me when I try to install behind a vpn because the setup.py tries to access a website). I'm not sure pytrec_eval is MIT compliant in terms of license (see cvangysel/pytrec_eval#44). Given that is used only for tests I moved the tests using it into a specific folder and ignored it in the test target. Happy to add a target that installs pytrec_eval and runs the missing tests.

@AmenRa AmenRa merged commit 94569f0 into AmenRa:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants