Add Makefile and move tests using pytrec_eval into a specific test folder #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
Makefile
with targets to simplify development. I would add more checks in future PRs.Note that
pytrec_eval
is not listed a dependency at the moment (and it creates problem to me when I try to install behind a vpn because the setup.pytries to access a website). I'm not sure
pytrec_eval` is MIT compliant in terms of license (see cvangysel/pytrec_eval#44).Given that is used only for tests I moved the tests using it into a specific folder and ignore it in the
test
target. Happy to add a target that install pytrec_eval and run the missing tests.