Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Add random and interval props to Histogram component #1363

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

drikusroor
Copy link
Contributor

@drikusroor drikusroor commented Nov 13, 2024

Re-added the random histogram bar changes as not to "help" the participant in the matching pairs experiment.

This PR adds the random prop (false by default) that makes the Histogram show random bar changes again. Additionally, the interval prop has been re-instated, which is used as the interval for random bar changes.

The PlayCard component then uses the random feature of the Histogram as it is used by the Matching Pairs game.

Fixes #1362

@drikusroor drikusroor self-assigned this Nov 13, 2024
Copy link
Contributor

@Evert-R Evert-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
For my taste it would be better to set the interval in the playcard to 200
I find 100 to be a bit distracting.

@drikusroor drikusroor merged commit 68e1bac into develop Nov 15, 2024
11 checks passed
@drikusroor drikusroor deleted the fix/honest-histogram-random branch November 15, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants