Skip to content

Commit

Permalink
Update nullable annotations (#140)
Browse files Browse the repository at this point in the history 
* Update Build (#87)

* adjust build props

* rename namespace

* remove versions form projects

* enable logging

* update deps 1

* use new test dl

* update tests

* change test

* update deps 2

* update deps 3

* removed a couple of warnings

* Versioning (#88)

* add gitversion

* nbgv and ci updates

* add global json

* test

* add delay

* update projects (#91)

* update projects

* remove url combine

* update projects

* Download manager update (#93)

* remove net48 target

* make dl fully async

* start generic verification context

* new verification

* fix local files get disposed

* disposing

* make download config immutable

* release 4.0

* fix not using io.abstractions

* add test cases

* Bump Microsoft.NET.Test.Sdk from 17.4.1 to 17.5.0 (#100)

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.4.1 to 17.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.4.1...v17.5.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump System.IO.Abstractions from 19.1.13 to 19.2.1 (#101)

Bumps [System.IO.Abstractions](https://github.com/TestableIO/System.IO.Abstractions) from 19.1.13 to 19.2.1.
- [Release notes](https://github.com/TestableIO/System.IO.Abstractions/releases)
- [Commits](TestableIO/System.IO.Abstractions@v19.1.13...v19.2.1)

---
updated-dependencies:
- dependency-name: System.IO.Abstractions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update deps

* New pipeline (#105)

* rename and move

* move ns

* renames

* add progress

* rename

* update progress

* added tests

* update ref

* rename and move

* move ns

* renames

* add progress

* rename

* update progress

* added tests

* update ref

* use .net 7 sdk

* use preview

* import parent

* add test

* update version

* add process elevation

* ignore test

* use config provider

* fix build from merge

* update and move verification

* update deps

* to class

* update deps

* add CurrentProcessInfo

* increase version

* merge cpi and elevation

* remove test

* move namespace

* don't move ns

* fix logger

* added base pipelines implemntations

* update deps

* Update dependencies (#133)

* update deps

* update to net 8.0

* Version 9.0 Impl (#134)

* project udpates

* start new file system package.

* make fs static extensions

* update filesystem stuff

* remove vanara and udpate windows fs

* some new lang features

* first changes so that it works with 9.0

* update verification

* fix linux ci restore

* remove dependency

* try other drive

* custom progress for test

* implement new hashing service

* add docs

* fix sha3 tests

* seal some classes

* make packable

* add frugallist

* some corrections and tests

* fix some downloader beahvior and rename tests

* fix linux tests (again...)

* update deps

* Version 10 impl (#136)

* move some Windows FS stuff to base package, enhance normalization and make some methods available

* remove unnecessary NET framework tests as those get run anyway on windows ci

* update action deps

* move some files

* update docs

* update version

* remove unused dependency

* remove more deps

* Main into develop (#139)

* Release version 9 (#135)

* Update Build (#87)

* adjust build props

* rename namespace

* remove versions form projects

* enable logging

* update deps 1

* use new test dl

* update tests

* change test

* update deps 2

* update deps 3

* removed a couple of warnings

* Versioning (#88)

* add gitversion

* nbgv and ci updates

* add global json

* test

* add delay

* update projects (#91)

* update projects

* remove url combine

* update projects

* Download manager update (#93)

* remove net48 target

* make dl fully async

* start generic verification context

* new verification

* fix local files get disposed

* disposing

* make download config immutable

* release 4.0

* fix not using io.abstractions

* add test cases

* Bump Microsoft.NET.Test.Sdk from 17.4.1 to 17.5.0 (#100)

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.4.1 to 17.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.4.1...v17.5.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump System.IO.Abstractions from 19.1.13 to 19.2.1 (#101)

Bumps [System.IO.Abstractions](https://github.com/TestableIO/System.IO.Abstractions) from 19.1.13 to 19.2.1.
- [Release notes](https://github.com/TestableIO/System.IO.Abstractions/releases)
- [Commits](TestableIO/System.IO.Abstractions@v19.1.13...v19.2.1)

---
updated-dependencies:
- dependency-name: System.IO.Abstractions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update deps

* New pipeline (#105)

* rename and move

* move ns

* renames

* add progress

* rename

* update progress

* added tests

* update ref

* rename and move

* move ns

* renames

* add progress

* rename

* update progress

* added tests

* update ref

* use .net 7 sdk

* use preview

* import parent

* add test

* update version

* add process elevation

* ignore test

* use config provider

* fix build from merge

* update and move verification

* update deps

* to class

* update deps

* add CurrentProcessInfo

* increase version

* merge cpi and elevation

* remove test

* move namespace

* don't move ns

* fix logger

* added base pipelines implemntations

* update deps

* Update dependencies (#133)

* update deps

* update to net 8.0

* Version 9.0 Impl (#134)

* project udpates

* start new file system package.

* make fs static extensions

* update filesystem stuff

* remove vanara and udpate windows fs

* some new lang features

* first changes so that it works with 9.0

* update verification

* fix linux ci restore

* remove dependency

* try other drive

* custom progress for test

* implement new hashing service

* add docs

* fix sha3 tests

* seal some classes

* make packable

* add frugallist

* some corrections and tests

* fix some downloader beahvior and rename tests

* fix linux tests (again...)

* update deps

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Release v10 (#138)

* Update Build (#87)

* adjust build props

* rename namespace

* remove versions form projects

* enable logging

* update deps 1

* use new test dl

* update tests

* change test

* update deps 2

* update deps 3

* removed a couple of warnings

* Versioning (#88)

* add gitversion

* nbgv and ci updates

* add global json

* test

* add delay

* update projects (#91)

* update projects

* remove url combine

* update projects

* Download manager update (#93)

* remove net48 target

* make dl fully async

* start generic verification context

* new verification

* fix local files get disposed

* disposing

* make download config immutable

* release 4.0

* fix not using io.abstractions

* add test cases

* Bump Microsoft.NET.Test.Sdk from 17.4.1 to 17.5.0 (#100)

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.4.1 to 17.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.4.1...v17.5.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump System.IO.Abstractions from 19.1.13 to 19.2.1 (#101)

Bumps [System.IO.Abstractions](https://github.com/TestableIO/System.IO.Abstractions) from 19.1.13 to 19.2.1.
- [Release notes](https://github.com/TestableIO/System.IO.Abstractions/releases)
- [Commits](TestableIO/System.IO.Abstractions@v19.1.13...v19.2.1)

---
updated-dependencies:
- dependency-name: System.IO.Abstractions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update deps

* New pipeline (#105)

* rename and move

* move ns

* renames

* add progress

* rename

* update progress

* added tests

* update ref

* rename and move

* move ns

* renames

* add progress

* rename

* update progress

* added tests

* update ref

* use .net 7 sdk

* use preview

* import parent

* add test

* update version

* add process elevation

* ignore test

* use config provider

* fix build from merge

* update and move verification

* update deps

* to class

* update deps

* add CurrentProcessInfo

* increase version

* merge cpi and elevation

* remove test

* move namespace

* don't move ns

* fix logger

* added base pipelines implemntations

* update deps

* Update dependencies (#133)

* update deps

* update to net 8.0

* Version 9.0 Impl (#134)

* project udpates

* start new file system package.

* make fs static extensions

* update filesystem stuff

* remove vanara and udpate windows fs

* some new lang features

* first changes so that it works with 9.0

* update verification

* fix linux ci restore

* remove dependency

* try other drive

* custom progress for test

* implement new hashing service

* add docs

* fix sha3 tests

* seal some classes

* make packable

* add frugallist

* some corrections and tests

* fix some downloader beahvior and rename tests

* fix linux tests (again...)

* update deps

* Version 10 impl (#136)

* move some Windows FS stuff to base package, enhance normalization and make some methods available

* remove unnecessary NET framework tests as those get run anyway on windows ci

* update action deps

* move some files

* update docs

* update version

* remove unused dependency

* remove more deps

* fix merge

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add nullable annotation

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  • Loading branch information
@AnakinRaW @dependabot
AnakinRaW and dependabot[bot] authored Mar 12, 2024
1 parent bf90cda commit ed513ce
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions src/CommonUtilities.FileSystem/src/Commonutilities.FileSystem.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Nullable" Version="1.3.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="System.IO.Abstractions" Version="20.0.28" />
<PackageReference Include="System.Memory" Version="4.5.5" />
<PackageReference Include="TestableIO.System.IO.Abstractions.Analyzers" Version="2022.0.0">
Expand Down
5 changes: 3 additions & 2 deletions src/CommonUtilities.FileSystem/src/Extensions/PathExtensions.cs
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Diagnostics.CodeAnalysis;
using System.IO;
using System.IO.Abstractions;
using System.Linq;
Expand Down Expand Up @@ -80,7 +81,7 @@ private static bool IsAnyDirectorySeparator(char c)
/// <param name="driveLetter">If <paramref name="path"/> is drive relative the drive's letter will be stored into this variable.
/// <see langword="null"/> if <paramref name="path"/> is not drive relative.</param>
/// <returns>Return <see langword="true"/> if <paramref name="path"/> is relative, but not absolute to a drive; otherwise, <see langword="false"/>.</returns>
public static bool IsDriveRelative(this IPath fsPath, string? path, out char? driveLetter)
public static bool IsDriveRelative(this IPath fsPath, string? path, [NotNullWhen(true)] out char? driveLetter)
{
driveLetter = null;

Expand All @@ -103,9 +104,9 @@ public static bool IsDriveRelative(this IPath fsPath, string? path, out char? dr
driveLetter = path[0];
return true;
}

return false;
}

return false;
}

Expand Down

0 comments on commit ed513ce

Please sign in to comment.