Release v10

.github/workflows/release.yml

@@ -16,16 +16,16 @@ jobs:
     needs: [test]
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout sources
-        uses: actions/checkout@v3
+      - name: Checkout source
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - name: Setup .NET
-        uses: actions/setup-dotnet@v3
+        uses: actions/setup-dotnet@v4
       - name: Create packages
         run: dotnet pack --configuration Release --output ./packages
       - name: Upload a Build Artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: NuGet packages
           path: packages/*.*
@@ -38,21 +38,21 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - name: Setup .NET
-        uses: actions/setup-dotnet@v3
-      - uses: actions/download-artifact@v3
+        uses: actions/setup-dotnet@v4
+      - uses: actions/download-artifact@v4
         with:
           name: NuGet packages
           path: packages
       - name: Push packages
         run: dotnet nuget push "packages/*.nupkg" --api-key ${{ secrets.NUGET_API_KEY }} --source https://api.nuget.org/v3/index.json
-      - uses: dotnet/[email protected].0
+      - uses: dotnet/[email protected].2
         id: nbgv
       - name: Create GitHub release
-        uses: softprops/action-gh-release@v1
+        uses: softprops/action-gh-release@v2
         with:
           name: v${{ steps.nbgv.outputs.SemVer2 }}
           tag_name: v${{ steps.nbgv.outputs.SemVer2 }}

.github/workflows/test.yml

@@ -18,16 +18,12 @@ jobs:
     runs-on: ${{ matrix.os }}
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: actions/setup-dotnet@v3
+      - uses: actions/setup-dotnet@v4
         with:
           dotnet-version: '8.0.x'
 
       - name: Build & Test in Release Mode
-        run: dotnet test --configuration Release --logger "GitHubActions"
-
-      - name: Build & Test .NET Framework
-        if: matrix.os == 'windows-latest'
-        run: dotnet test --configuration Release -f net48 --logger "GitHubActions"
+        run: dotnet test --configuration Release --logger "GitHubActions"

src/CommonUtilities.FileSystem.Windows/src/WindowsPathExtensions.cs

@@ -1,10 +1,8 @@
 using System;
 using System.IO;
 using System.IO.Abstractions;
-using System.Runtime.CompilerServices;
 using System.Security.AccessControl;
 using System.Security.Principal;
-using System.Text.RegularExpressions;
 
 namespace AnakinRaW.CommonUtilities.FileSystem.Windows;
 
@@ -13,93 +11,6 @@ namespace AnakinRaW.CommonUtilities.FileSystem.Windows;
 /// </summary>
 public static class WindowsPathExtensions
 {
-    private static readonly Regex RegexInvalidName =
-        new("^(COM\\d|CLOCK\\$|LPT\\d|AUX|NUL|CON|PRN|(.*[\\ud800-\\udfff]+.*))$", RegexOptions.IgnoreCase);
-
-    private static readonly char[] InvalidNameChars = Path.GetInvalidFileNameChars();
-
-    /// <summary>
-    /// Checks whether a file name is valid on Windows.
-    /// </summary>
-    /// <param name="_"></param>
-    /// <param name="fileName">The file name to validate.</param>
-    /// <returns><see langword="true"/> if the file name is valid; Otherwise, <see langword="false"/>.</returns>
-    /// <exception cref="PlatformNotSupportedException">If the current system is not Windows.</exception>
-    public static FileNameValidationResult IsValidFileName(this IPath _, string fileName)
-    {
-        ThrowHelper.ThrowIfNotWindows();
-
-        if (string.IsNullOrEmpty(fileName))
-            return FileNameValidationResult.NullOrEmpty;
-
-        var fileNameSpan = fileName.AsSpan();
-
-        if (!EdgesValid(fileNameSpan, out var whiteSpaceError))
-            return whiteSpaceError
-                ? FileNameValidationResult.LeadingOrTrailingWhiteSpace
-                : FileNameValidationResult.TrailingPeriod;
-
-        if (ContainsInvalidChars(fileNameSpan))
-            return FileNameValidationResult.InvalidCharacter;
-
-        if (RegexInvalidName.IsMatch(fileName))
-            return FileNameValidationResult.WindowsReserved;
-
-        return FileNameValidationResult.Valid;
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private static bool ContainsInvalidChars(ReadOnlySpan<char> value)
-    {
-        foreach (var t in value)
-            if (IsInvalidFileCharacter(t))
-                return true;
-
-        return false;
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private static bool IsInvalidFileCharacter(char c)
-    {
-        // Additional check for invalid Windows file name characters
-        foreach (var charToCheck in InvalidNameChars)
-        {
-            if (charToCheck == c)
-                return true;
-        }
-
-        return false;
-    }
-
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private static bool EdgesValid(ReadOnlySpan<char> value, out bool whiteSpace)
-    {
-        whiteSpace = false;
-
-        if (value[0] is '\x0020')
-        {
-            whiteSpace = true;
-            return false;
-        }
-
-#if NET
-        var lastChar = value[^1];
-#else
-        var lastChar = value[value.Length - 1];
-#endif
-        if (lastChar is '\x0020')
-        {
-            whiteSpace = true;
-            return false;
-        }
-
-        if (lastChar is '.')
-            return false;
-
-        return true;
-    }
-
     // Based on: https://stackoverflow.com/questions/1410127/c-sharp-test-if-user-has-write-access-to-a-folder
     /// <summary>
     /// Checks whether the current executing user that the requested rights on a given location.

src/CommonUtilities.FileSystem.Windows/test/WindowsPathServiceTest.cs

@@ -1,90 +1,12 @@
 using System.IO;
 using System.Security.AccessControl;
 using AnakinRaW.CommonUtilities.Testing;
-using Testably.Abstractions.Testing;
 using Xunit;
 
 namespace AnakinRaW.CommonUtilities.FileSystem.Windows.Test;
 
 public class WindowsPathServiceTest
 {
-    private readonly MockFileSystem _fileSystem = new();
-
-    [PlatformSpecificTheory(TestPlatformIdentifier.Windows)]
-    [InlineData("123")]
-    [InlineData("123.txt")]
-    [InlineData("123..txt")]
-    [InlineData("fileNameWithCase")]
-    [InlineData("fileNameWith_underscore")]
-    [InlineData("fileNameWith-hyphen")]
-    [InlineData(".test")]
-    [InlineData("LPT12")]
-    [InlineData("COM12")]
-    [InlineData("NUL.txt")] // Though it's not recommend by MS, it's actually allowed to use this name in explorer
-    [InlineData("nameWithNonASCII_ö")]
-    [InlineData("\u0160")]
-    public void Test_IsValidFileName_ValidNames(string input)
-    {
-        Assert.Equal(FileNameValidationResult.Valid, _fileSystem.Path!.IsValidFileName(input));
-    }
-
-
-    [PlatformSpecificTheory(TestPlatformIdentifier.Windows)]
-    [InlineData(null, FileNameValidationResult.NullOrEmpty)]
-    [InlineData("", FileNameValidationResult.NullOrEmpty)]
-    [InlineData("     ", FileNameValidationResult.LeadingOrTrailingWhiteSpace)]
-    [InlineData("\0", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("123\0", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("123\t", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("123\r", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("123\n", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("nameWithTrailingSpace ", FileNameValidationResult.LeadingOrTrailingWhiteSpace)]
-    [InlineData("   nameWithLeadingSpace", FileNameValidationResult.LeadingOrTrailingWhiteSpace)]
-    [InlineData("my\\path", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("my/path", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("illegalChar_<", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("illegalChar_>", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("illegalChar_|", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("illegalChar_:", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("illegalChar_*", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("illegalChar_?", FileNameValidationResult.InvalidCharacter)]
-    [InlineData(".", FileNameValidationResult.TrailingPeriod)]
-    [InlineData("..", FileNameValidationResult.TrailingPeriod)]
-    [InlineData("test....", FileNameValidationResult.TrailingPeriod)]
-    [InlineData("test..", FileNameValidationResult.TrailingPeriod)]
-    [InlineData("test.", FileNameValidationResult.TrailingPeriod)]
-    [InlineData("con", FileNameValidationResult.WindowsReserved)]
-    [InlineData("PRN", FileNameValidationResult.WindowsReserved)]
-    [InlineData("AUX", FileNameValidationResult.WindowsReserved)]
-    [InlineData("NUL", FileNameValidationResult.WindowsReserved)]
-    [InlineData("COM0", FileNameValidationResult.WindowsReserved)]
-    [InlineData("COM1", FileNameValidationResult.WindowsReserved)]
-    [InlineData("COM2", FileNameValidationResult.WindowsReserved)]
-    [InlineData("COM3", FileNameValidationResult.WindowsReserved)]
-    [InlineData("COM4", FileNameValidationResult.WindowsReserved)]
-    [InlineData("COM5", FileNameValidationResult.WindowsReserved)]
-    [InlineData("COM6", FileNameValidationResult.WindowsReserved)]
-    [InlineData("COM7", FileNameValidationResult.WindowsReserved)]
-    [InlineData("COM8", FileNameValidationResult.WindowsReserved)]
-    [InlineData("COM9", FileNameValidationResult.WindowsReserved)]
-    [InlineData("lpt0", FileNameValidationResult.WindowsReserved)]
-    [InlineData("lpt1", FileNameValidationResult.WindowsReserved)]
-    [InlineData("lpt2", FileNameValidationResult.WindowsReserved)]
-    [InlineData("lpt3", FileNameValidationResult.WindowsReserved)]
-    [InlineData("lpt4", FileNameValidationResult.WindowsReserved)]
-    [InlineData("lpt5", FileNameValidationResult.WindowsReserved)]
-    [InlineData("lpt6", FileNameValidationResult.WindowsReserved)]
-    [InlineData("lpt7", FileNameValidationResult.WindowsReserved)]
-    [InlineData("lpt8", FileNameValidationResult.WindowsReserved)]
-    [InlineData("lpt9", FileNameValidationResult.WindowsReserved)]
-    [InlineData("\\file", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("/file", FileNameValidationResult.InvalidCharacter)]
-    [InlineData("|file", FileNameValidationResult.InvalidCharacter)]
-    public void Test_IsValidFileName_InvalidNames(string input, FileNameValidationResult expected)
-    {
-        Assert.Equal(expected, _fileSystem.Path!.IsValidFileName(input));
-    }
-
     [PlatformSpecificTheory(TestPlatformIdentifier.Windows)]
     [InlineData(null, FileSystemRights.Read, true)]
     [InlineData(null, FileSystemRights.Write, true)]

src/CommonUtilities.FileSystem/src/Extensions/FileNameValidator.cs

@@ -0,0 +1,6 @@
+namespace AnakinRaW.CommonUtilities.FileSystem;
+
+internal class FileNameValidator
+{
+
+}